Remove donjamayanne.jupyter integration#7277
Merged
kimadeline merged 1 commit intomicrosoft:masterfrom Sep 16, 2019
Merged
Conversation
|
|
mikeroll
force-pushed
the
remove-jupyter
branch
from
d796e7b to
2f5628a
Compare
mikeroll
force-pushed
the
remove-jupyter
branch
from
2f5628a to
b695faf
Compare
Codecov Report
@@ Coverage Diff @@
## master #7277 +/- ##
==========================================
+ Coverage 58.33% 58.38% +0.05%
==========================================
Files 493 492 -1
Lines 21661 21610 -51
Branches 3486 3475 -11
==========================================
- Hits 12635 12618 -17
+ Misses 8243 8214 -29
+ Partials 783 778 -5
Continue to review full report at Codecov.
|
kimadeline
approved these changes
Sep 16, 2019
kimadeline
left a comment
kimadeline
left a comment
There was a problem hiding this comment.
Thank you for your contribution @mikeroll !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6052
Appropriate comments and documentation strings in the codeHas sufficient logging.Has telemetry for enhancements.Unit tests & system/integration tests are added/updatedTest plan is updated as appropriatepackage-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)The wiki is updated with any design decisions/details.