Skip to content

Validation fixes for color theming in plot selection list#8224

Merged
IanMatthewHuff merged 1 commit intomicrosoft:masterfrom
IanMatthewHuff:dev/ianhu/plotSelectionBug
Oct 25, 2019
Merged

Validation fixes for color theming in plot selection list#8224
IanMatthewHuff merged 1 commit intomicrosoft:masterfrom
IanMatthewHuff:dev/ianhu/plotSelectionBug

Conversation

@IanMatthewHuff
Copy link
Copy Markdown
Member

Validation fixes for follow up to:
#8212

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@IanMatthewHuff IanMatthewHuff added the no-changelog No news entry required label Oct 25, 2019
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #8224 into master will increase coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8224      +/-   ##
==========================================
+ Coverage   58.32%   58.67%   +0.35%     
==========================================
  Files         504      504              
  Lines       22740    23107     +367     
  Branches     3725     3725              
==========================================
+ Hits        13262    13558     +296     
- Misses       8601     8672      +71     
  Partials      877      877
Impacted Files Coverage Δ
src/client/testing/serviceRegistry.ts 48.64% <0%> (-44.21%) ⬇️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 66.66% <0%> (-33.34%) ⬇️
src/client/formatters/serviceRegistry.ts 75% <0%> (-25%) ⬇️
...ience/jupyter/jupyterDebuggerRemoteNotSupported.ts 75% <0%> (-25%) ⬇️
src/client/common/utils/icons.ts 83.33% <0%> (-16.67%) ⬇️
src/client/testing/codeLenses/main.ts 44.44% <0%> (-15.56%) ⬇️
src/client/api.ts 78.57% <0%> (-11.43%) ⬇️
src/client/common/utils/version.ts 77.77% <0%> (-1.39%) ⬇️
src/client/providers/providerUtilities.ts 83.33% <0%> (-1.29%) ⬇️
...lient/datascience/jupyter/jupyterSelfCertsError.ts 100% <0%> (ø) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 847a440...5790b7d. Read the comment docs.

@IanMatthewHuff IanMatthewHuff merged commit 633c8cc into microsoft:master Oct 25, 2019
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/plotSelectionBug branch October 25, 2019 23:03
@lock lock Bot locked as resolved and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants