Skip to content

[Feature] Add explicit assertion for wait result in ActionBar smoke test #2675

@EmmaYuan1015

Description

@EmmaYuan1015
Description
Background
In the ActionBar smoke test, the wait helper returns false when a timeout occurs. However, the test does not validate this return value.
Problem
If the expected packager state is not reached within the timeout period, the test may still pass, resulting in a false positive outcome.
Impact

Reduced reliability of smoke test signals
Potential regressions going undetected in CI pipelines

Expected Behavior
The test should explicitly fail when the wait condition is not satisfied within the defined timeout.
Proposed Fix

Capture and validate the return value of the wait helper
Add an explicit assertion with a clear failure message when timeout occurs

Acceptance Criteria

The test fails when the packager state does not contain the expected value within the timeout
The test passes when the expected state is observed
Smoke tests compile and run successfully in CI

Scope

Applies only to the ActionBar smoke test
No impact on production extension behavior``

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions