Conversation
Member
|
Looks good to me! 👍 that you make it explicit which grammars an injection targets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pull requests adds support for external injection grammars. Injection grammars look like regular grammars, with a scope name as identifier, but have the property 'injectionSelector'.
In text mate, injection grammars are applied to all grammars. I changed that in our implementation:
We only use the injection grammars that are configured for the current language scope. The goal of this limitation is to avoid a performance regression due to many injections in the system.
The new API
getInjectionson theIGrammarLocatortakes a language scope (e.g. 'source.js') and returns the grammar identifiers of all injection grammars to apply (e.g. [ 'text.todo', 'text.hyperlink']).This API will be implemented on the client side (in VSCode). The idea is that each contributed injection grammar also specifies a list of grammar it applies to.
microsoft/vscode#6331 is the pull request on the VS Code side.