Skip to content

Consider adding a command object to TerminalLink rather than the handleTerminalLink method #101457

@eamodio

Description

@eamodio

Testing #101300

Again, this is mostly API ergonomics, but this would keep consistency with other APIs (CodeLens, StatusBarItems, TreeItems, etc). It also helps guide the usage of a command being required to return a link, and somewhat avoids calls to handleTerminalLink that take no action.

Additionally since the command object has a title property, that could be used in place of the tooltip property as well.

re: #101391 (comment)

/cc @jrieken

Metadata

Metadata

Assignees

Labels

apiterminalGeneral terminal issues that don't fall under another labelterminal-linksunder-discussionIssue is under discussion for relevance, priority, approach

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions