start debug multi folder workspace startup dialog

[rvanbree]

Issue Type: Bug

Dialog pops up when debugging starts:
'${workspaceFolder}' can not be resolved in a multi folder workspace. Scope this variable using ':' and a workspace folder name.

VS Code version: Code 1.47.2 (17299e4, 2020-07-15T18:18:50.054Z)
OS version: Darwin x64 19.5.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz (16 x 2300)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off_ok webgl: enabled webgl2: enabled
Load (avg)	2, 2, 2
Memory (System)	32.00GB (0.02GB free)
Process Argv
Screen Reader	no
VM	0%

Extensions (13)

Extension	Author (truncated)	Version
npm-intellisense	chr	1.3.0
vscode-eslint	dba	2.1.8
githistory	don	0.6.8
json-tools	eri	1.0.2
docthis	joe	0.7.1
git-graph	mhu	1.24.0
vscode-docker	ms-	1.4.1
js-debug-nightly	ms-	2020.7.2317
sqltools	mtx	0.22.11
sqltools-driver-mysql	mtx	0.1.0
vscode-graphql	Pri	0.2.14
vscode-icons	vsc	10.2.0
material-theme	zhu	3.8.5

(1 theme extensions excluded)

[weinand]

If possible, please share your launch config us.

[AskAlice]

@weinand

see: #103099 and #94725

This is in the same workspace config, i am only sharing what is necessary.

This worked before updating VSCode to 1.47 and i'd imagine the underlying cause may be in node-debug, as I can still launch react, just not apollo.

I tried to remove every instance of ${workspaceFolder} within the apollo launch config, but still threw the error.

"folders": [
    {
      "name": "React",
      "path": "app"
    },
    {
      "name": "apollo",
      "path": "../redacted"
    },
    {
      "name": "Deployment",
      "path": "../.."
    },
    {
      "name": "redacted",
      "path": "../../../.."
    }
  ],

"launch": {
    "configurations": [
      {
        "name": "React: Chrome",
        "type": "chrome",
        "request": "launch",
        "url": "http://localhost:3000",
        "webRoot": "${workspaceFolder:React}/src",
        "sourceMapPathOverrides": {
          "webpack:///src/*": "${webRoot}/*"
        },
        "presentation": {
          "hidden": false,
          "group": "React",
          "order": 1
        }
      },
      {
        "name": "React: Debug Unit Tests",
        "type": "node",
        "request": "launch",
        "cwd": "${workspaceFolder:React}",
        "runtimeExecutable": "${workspaceFolder:React}/node_modules/.bin/react-scripts",
        "args": [
          "test",
          "--runInBand",
          "--no-cache",
          "--watchAll=false",
          "--env=jsdom"
        ],
        "protocol": "inspector",
        "console": "integratedTerminal",
        "internalConsoleOptions": "neverOpen",
        "env": {
          "CI": "true"
        },
        "skipFiles": [
          "<node_internals>/**/*.js",
          "${workspaceFolder:React}/node_modules/**/*.js",
          "${workspaceFolder:React}node_modules\\**\\*.js",
          "<node_internals>/**/*.js"
        ],
        "disableOptimisticBPs": true,
        "presentation": {
          "hidden": false,
          "group": "React",
          "order": 1
        }
      },
      {
        "name": "apollo-server",
        "trace": "verbose",
        "type": "node",
        "request": "launch",
        "cwd": "${workspaceFolder:apollo}",
        "runtimeExecutable": "${workspaceFolder:apollo}/node_modules/.bin/ts-node-dev",
        "args": [
          "--respawn",
          "--inspect",
          "--inspect-brk=9229",
          "--transpileOnly",
          "--ignore-watch=node_modules",
          "./src/server.ts"
        ],
        "protocol": "inspector",
        "console": "integratedTerminal",
        "internalConsoleOptions": "neverOpen",
        "env": {
          "CI": "true"
        },
        "skipFiles": [
          "<node_internals>/**/*.js",
          "${workspaceFolder:apollo}/node_modules/**/*.js",
          "${workspaceFolder:apollo}node_modules\\**\\*.js",
          "<node_internals>/**/*.js"
        ],
        "disableOptimisticBPs": true,
        "presentation": {
          "hidden": false,
          "group": "apollo-server",
          "order": 1
        },
        "port": 9229,
        "restart": true
      }
    ],
    "compounds": [
      {
        "name": "Full Stack Debugging",
        "configurations": [
          "React: Chrome",
          "apollo-server"
        ],
        "presentation": {
          "hidden": false,
          "group": "all",
          "order": 10
        }
      }
    ]
  }

[connor4312]

Please try setting your launch "type": "pwa-node", instead of node and `"type": "pwa-chrome", instead of chrome -- we've made improvements here.

[rvanbree]

I tried that. No change, I still get the same error/warning dialog.

…

On Mon, Jul 27, 2020, 5:52 PM Connor Peet ***@***.***> wrote: Please try setting your launch "type": "pwa-node", instead of node and `"type": "pwa-chrome", instead of chrome -- we've made improvements here. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#103261 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDVBZX5ZZWPRKH4YCCM723R5YHM3ANCNFSM4PG4I27A> .

[rvanbree]

{ "version": "0.2.0", "configurations": [ { "type": "pwa-node", "request": "launch", "name": "Launch via NPM", "runtimeExecutable": "npm", "console": "integratedTerminal", "runtimeArgs": [ "run-script", "start:dev" ], "skipFiles": [ "<node_internals>/**" ] }, { "type": "pwa-node", "request": "launch", "name": "Launch Vital-Signs-Service", "program": "${workspaceFolder}/server.js", "envFile": "${workspaceFolder}/.env", "console": "integratedTerminal", "args": [ "--inspect=9229", "--runInBand", "--config", "--require tsconfig-paths/register", "--require dotenv/config" ], "skipFiles": [ "<node_internals>/**" ] }, { "type": "node", "request": "launch", "name": "Debug Jest Tests", "cwd": "${workspaceFolder}", "envFile": "${workspaceFolder}/.env", "args": [ "--inspect-brk", "${workspaceRoot}/node_modules/.bin/jest", "--runInBand", "--config", "${workspaceRoot}/jest.config.js" ], "windows": { "args": [ "--inspect-brk", "${workspaceRoot}/node_modules/jest/bin/jest.js", "--runInBand", "--config", "${workspaceRoot}/jest.config.js" ] }, "console": "integratedTerminal", "internalConsoleOptions": "neverOpen" }, { "type": "node", "request": "attach", "name": "Debug Attach VSS 9229", "protocol": "inspector", "port": 9229, "restart": true, "localRoot": "${workspaceFolder}", "remoteRoot": ".", "sourceMaps": true }, { "type": "node", "request": "launch", "name": "Jest Current File", "program": "${workspaceFolder}/node_modules/.bin/jest", "args": [ "${fileBasenameNoExtension}", "--config", "jest.config.js" ], "console": "integratedTerminal", "internalConsoleOptions": "neverOpen", "disableOptimisticBPs": true, "windows": { "program": "${workspaceFolder}/node_modules/jest/bin/jest", } } ] }

…

On Fri, Jul 24, 2020 at 11:21 AM Andre Weinand ***@***.***> wrote: If possible, please share your launch config us. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#103261 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDVBZXACW4WF63LAQSC6MTR5G7J7ANCNFSM4PG4I27A> .

[connor4312]

@rvanbree if you have that in your workspace config, then that's expected, since the workspaceFolders you have aren't scoped to a single folder.

[rvanbree]

No that was launch.json. sorry

…

On Tue, Jul 28, 2020, 10:14 AM Connor Peet ***@***.***> wrote: @rvanbree <https://github.com/rvanbree> if you have that in your workspace config, then that's expected, since the workspaceFolders you have aren't scoped to a single folder. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#103261 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDVBZTHIX634FFCX5HQACDR532N3ANCNFSM4PG4I27A> .