Skip to content

Ripgrep search provider incorrectly treats search.exclude globs as non-strict. #104204

@JacksonKearl

Description

@JacksonKearl

The include and exclude fields in the search view/search editor use a "loose" glob interpretation:
test -> **/test/**, **/test
.test -> **/*.test
etc.

search.exclude however uses strict globs. However, the ripgrep search provider seems to be interpreting the globs in search.exclude loosely:

For instance: Try searching "searchEditor" in vscode standard:
image

Now try adding "**/workbench": true to search.exclude. This should only remove results with basename workbench. In actuality, it filters out all of **/workbench/**:
image

Metadata

Metadata

Labels

*out-of-scopePosted issue is not in scope of VS CodesearchSearch widget and operation issues

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions