Some controls are not read correctly in settings UI with screen readers.

[jareds]

Issue Type: Bug

@isidorn

1. Insure you are running with NVDA version 20.2. Other versions will probably show the same behavior.
2. Install the java extention pac.
3. Open the settings UI.
4. Go to extentions -> java
5. Tab through until you hear "edit in settings.json"
   NVDA does not announce what I am actually goint to edit in settings.json if I click the button.

VS Code version: Code - Insiders 1.50.0-insider (9e50567, 2020-09-16T06:49:37.816Z)
OS version: Windows_NT x64 10.0.19041
Remote OS version: Linux x64 4.19.84-microsoft-standard

System Info

Item	Value
CPUs	Intel(R) Core(TM) i3-7100U CPU @ 2.40GHz (4 x 2400)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: disabled_off opengl: enabled_on protected_video_decode: enabled rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	7.87GB (1.89GB free)
Process Argv	--crash-reporter-id 13f64f2b-f4fe-4a58-989d-cf59898848a6
Screen Reader	yes
VM	0%

Item	Value
Remote	Dev Container: Go
OS	Linux x64 4.19.84-microsoft-standard
CPUs	Intel(R) Core(TM) i3-7100U CPU @ 2.40GHz (4 x 2400)
Memory (System)	6.10GB (2.09GB free)
VM	0%

Extensions (12)

Extension	Author (truncated)	Version
vscode-lombok	Gab	1.0.1
javadoc-tools	mad	1.4.0
remote-containers	ms-	0.141.0
remote-wsl	ms-	0.44.5
java	red	0.67.0
sonarlint-vscode	Son	1.17.0
vscodeintellicode	Vis	1.2.10
vscode-java-debug	vsc	0.28.0
vscode-java-dependency	vsc	0.13.0
vscode-java-pack	vsc	0.10.0
vscode-java-test	vsc	0.24.2
vscode-maven	vsc	0.24.2

[isidorn]

If I understand the issue correctly: Some complex settings we do not allow to edit in the settings editor, for that we have to poen the settings.json.
So the fix would be that the aria label of the "edit in settings.json" button also controls the setting name. So for example
"edit terminal.integrated.automationShell.linux in settings.json"

[jareds]

That is correct and the way you describe it is how I would expect it to behave.

…

On Fri, Sep 18, 2020 at 3:53 AM Isidor Nikolic ***@***.***> wrote: If I understand the issue correctly: Some complex settings we do not allow to edit in the settings editor, for that we have to poen the settings.json. So the fix would be that the aria label of the "edit in settings.json" button also controls the setting name. So for example "edit terminal.integrated.automationShell.linux in settings.json" — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#106975 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA5FIEFOIBXXLHEU7OPU6TSGMGX7ANCNFSM4RRIUZJQ> .