Inform user about slow shutdown for pending editor auto saves

[eamodio]

• VSCode Version: 1.52.0-insiders
• Local OS Version: Windows 10.0.20262.0 (current Dev Channel) ARM64 (Surface Pro X)
• Remote OS Version: Windows 10.0.19042.0 (current Beta Channel)
• Remote Extension/Connection Type: SSH

I've had this happen a few times now, where auto-save during a connection interrupt, basically kills the whole window (can't even reload)

Steps to Reproduce:

1. Make sure you have auto-save set to save on focus change
2. Connect to remote, edit a file
3. Do something to cause the remote to become unavailable
4. Get disconnect dialog, which causes a focus change and causes the file to try to be saved (which will fail)
5. Try to reload the window (I don't know if the remote needs to be back or not) and it will clear the dialog, but status bar says remote is disconnected
6. The unsaved file is still unsaved and you can't close it or open any other files, can't even run Reload Window from the command palette -- have to exit vscode completely usually by killing it via taskman

[roblourens]

Oh, reloading is blocked on save, which can't complete?

[eamodio]

Yup, exactly

[bpasero]

I am able to reproduce locally doing this:

• run out of sources
• click on "Remote Test Resolver - New Window" from the remote menu
• configure auto save to a delay of 500s
• open a folder in the test remote
• open a file
• make it dirty
• open the process explorer
• find the PID of the test remote server
• from a command line kill <pid>
• the reconnection dialog appears
• wait for it to eventually show a native dialog
• click reload window
• nothing happens

I traced this all the way down to a file system call we do to the remote file system. IF auto save is enabled, instead of relying on our backups, we simply try to save all dirty files since auto save is enabled anyway. However, this call never resolves, i.e. I do not see this handle call ever triggered:

vscode/src/vs/base/parts/ipc/common/ipc.ts

Line 554 in fc8805d

switch (response.type) {

This means that:

• the window thinks the file is being saved and waits
• the file save is running but never completes (for an unknown reason)
• there is no progress reporting to the user
• there is no error reporting

@alexdima might need your help here to further understand what happens when a remote connection is not working anymore. It seems to me, IPC calls are queued and never resolve. Would appreciate some insights from your end.

Meanwhile on my end and I can maybe try to show progress when the save takes long, possibly allowing to cancel this and fallback to backups in that case.

[bpasero]

I now understand why things like "File > Open" do not work because we seem to be doing a file service call here to figure out if the default URI exists:

vscode/src/vs/workbench/services/dialogs/browser/simpleFileDialog.ts

Line 256 in e16d1f0

stat = await this.fileService.resolve(this.options.defaultUri);

This call never returns and as such the dialog never opens.

As for Quit and Reload not working: same reason, we wait for the file to be saved and this never finishes.

[bpasero]

As Alex was pointing out, it makes sense to hold any requests as long as reconnection attempts are made. But in this case I see a native dialog telling me that no reconnection is possible and I have to reload. So in this case we should maybe error each pending IPC request. In this case the workbench would handle it properly on shutdown 👍