Uncaught errors (from Git extension?) causing test failures in vscode-test

[bwateratmsft]

• VS Code Version: 1.54.0, 1.54.1, vscode-test
• OS Version: OS X test pipeline

Recently our build pipelines for the Docker extension have all begun failing on Mac specifically (Linux and Windows do not show this misbehavior). I think the failures began when 1.54.0 was released yesterday--older commits of our code, which built fine before, now fail in exactly the same way. What's strange is only some of our tests are failing, but it is somewhat consistent which...

The error:

     Uncaught Error: read ENOTCONN
  	at tryReadStart (net.js:573:20)
  	at Socket._read (net.js:584:5)
  	at Socket.Readable.read (_stream_readable.js:467:10)
  	at Socket.read (net.js:624:39)
  	at new Socket (net.js:376:12)
  	at Object.Socket (net.js:267:41)
  	at createSocket (internal/child_process.js:314:14)
  	at ChildProcess.spawn (internal/child_process.js:437:23)
  	at Object.spawn (child_process.js:557:9)
  	at t.Git.spawn (.vscode-test/vscode-darwin-1.54.1/Visual Studio Code.app/Contents/Resources/app/extensions/git/dist/main.js:1:89263)
  	at t.Git._exec (.vscode-test/vscode-darwin-1.54.1/Visual Studio Code.app/Contents/Resources/app/extensions/git/dist/main.js:1:88431)
  	at t.Git.exec (.vscode-test/vscode-darwin-1.54.1/Visual Studio Code.app/Contents/Resources/app/extensions/git/dist/main.js:1:88272)
  	at t.Git.getRepositoryRoot (.vscode-test/vscode-darwin-1.54.1/Visual Studio Code.app/Contents/Resources/app/extensions/git/dist/main.js:1:87521)
  	at g.openRepository (.vscode-test/vscode-darwin-1.54.1/Visual Studio Code.app/Contents/Resources/app/extensions/git/dist/main.js:10:406906)
  	at n (.vscode-test/vscode-darwin-1.54.1/Visual Studio Code.app/Contents/Resources/app/extensions/git/dist/main.js:1:24277)
  	at processTicksAndRejections (internal/process/task_queues.js:97:5)

The build logs are public and can be viewed here: https://dev.azure.com/ms-azuretools/AzCode/_build/results?buildId=31685&view=logs&j=a5e52b91-c83f-5429-4a68-c246fc63a4f7&t=b7b7a6e6-b49b-50ea-fca3-f91483add993

Here's an example of the same commit succeeding a few days earlier with 1.53.2: https://dev.azure.com/ms-azuretools/AzCode/_build/results?buildId=31628&view=logs&j=a5e52b91-c83f-5429-4a68-c246fc63a4f7&t=b7b7a6e6-b49b-50ea-fca3-f91483add993

[ejizba]

Fwiw we saw these errors, too. I got it working again by downgrading the agent from "macOS-latest" to "macOS-10.14". Not sure if that means the agent was the problem or if there's still some underlying VS Code issue...

[bwateratmsft]

Good to know, I'll try that. That makes me think--something to do with Apple Silicon?

[patroza]

The same error occurs just on my x86 MBP MacOS 11.2.2. starting VSCode on certain repositories.
It may also happen a little later after startup. Had to downgrade to 1.53.

[ashgti]

I believe this error is happening because the child process output streams do not have an .on('error') handler registered.

I had the same type of stack trace occur for child processes spawned by my extension.

[ashgti]

I believe you could add an on('error') handler to child.stdout and child.stderr here

vscode/extensions/git/src/git.ts

Lines 214 to 229 in a699ffa

	let result = Promise.all<any>([
	new Promise<number>((c, e) => {
	once(child, 'error', cpErrorHandler(e));
	once(child, 'exit', c);
	}),
	new Promise<Buffer>(c => {
	const buffers: Buffer[] = [];
	on(child.stdout!, 'data', (b: Buffer) => buffers.push(b));
	once(child.stdout!, 'close', () => c(Buffer.concat(buffers)));
	}),
	new Promise<string>(c => {
	const buffers: Buffer[] = [];
	on(child.stderr!, 'data', (b: Buffer) => buffers.push(b));
	once(child.stderr!, 'close', () => c(Buffer.concat(buffers).toString('utf8')));
	})
	]) as Promise<[number, Buffer, string]>;

to fix this issue.

[lramos15]

Sorry for the late update everyone. Is this still an issue @bwateratmsft

[bwateratmsft]

When we lowered the pipeline version from macOS-latest to macOS-10.14, as Eric suggested here, the issue went away. Let me try putting it back to latest and see what happens.

[bwateratmsft]

The build was successful, so I'd say this is fixed now.