Cannot find replace large multiline text

[cdalexndr]

• VS Code Version: 1.54.2
• OS Version: Win10 19041.867

Steps to Reproduce:

1. find or replace large multiline text (~ 100 line stacktrace containing ~14.000 chars)
2. Result: bottom right warning Invalid regular expression: containing text.

Note that selecting fewer lines (ex: 10 lines) works.

Does this issue occur when all extensions are disabled?: Yes

[alexdima]

@cdalexndr How long is your search string? By using binary search I found that JavaScript's (v8's) regex length limit is 41943041 (41MB) which seems to be large enough. I tried 41 million xs. Does this reproduce with any search string or only this specific one?

[cdalexndr]

sample.log

1. Ctrl-A
2. Ctrl-C
3. Ctrl-F
4. Ctrl-V => No results (invalid!)
5. Esc
6. Ctrl-F
7. Invalid regular expression:...

[cdalexndr]

Need to remove label needs more info

[hediet]

This throws the same error:

r = new RegExp(" org\\.springframework\\.transaction\\.aspectj\\.AbstractTransactionAspect\\.ajc\\$around\\$org_springframework_transaction_aspectj_AbstractTransactionAspect\\$1\\$2a73e96cproceed\\(AbstractTransactionAspect\\.aj:67\\) ~\\[spring-aspects-5\\.3\\.3\\.jar:5\\.3\\.3\\]\\n\tat org\\.springframework\\.transaction\\.aspectj\\.AbstractTransactionAspect\\$AbstractTransactionAspect\\$1\\.proceedWithInvocation\\(AbstractTransactionAspect\\.aj:73\\) ~\\[spring-aspects-5\\.3\\.3\\.jar:5\\.3\\.3\\]\\n\tat org\\.springframework\\.transaction\\.interceptor\\.TransactionAspectSupport\\.invokeWithinTransaction\\(TransactionAspectSupport\\.java:388\\) ~\\[spring-tx-5\\.3\\.3\\.jar:5\\.3\\.3\\]\\n\tat org\\.springframework\\.transaction\\.aspectj\\.AbstractTransactionAspect\\.ajc\\$around\\$org_springframework_transaction_aspectj_AbstractTransactionAspect\\$1\\$2a73e96c\\(AbstractTransactionAspect\\.aj:71\\) ~\\[spring-aspects-5\\.3\\.3\\.jar:5\\.3\\.3\\]\\n\tat jdk\\.internal\\.reflect\\.GeneratedMethodAccessor453\\.invoke\\(Unknown Source\\) ~\\[na:na\\]\\n\tat java\\.base\\/jdk\\.internal\\.reflect\\.DelegatingMethodAccessorImpl\\.invoke\\(DelegatingMethodAccessorImpl\\.java:43\\) ~\\[na:na\\]\\n\tat java\\.base\\/java\\.lang\\.reflect\\.Method\\.invoke\\(Method\\.java:566\\) ~\\[na:na\\]\\n\tat org\\.\\.web\\.method\\.support\\.InvocableHandlerMethod\\.doInvoke\\(InvocableHandlerMethod\\.java:197\\) ~\\[spring-web-5\\.3\\.3\\.jar:5\\.3\\.3\\]\\n\tat org\\.springframework\\.web\\.method\\.support\\.InvocableHandlerMethod\\.invokeForRequest\\(InvocableHandlerMethod\\.java:141\\) ~\\[spring-web-5\\.3\\.3\\.jar:5\\.3\\.3\\]\\n\tat org\\.springframework\\.web\\.servlet\\.mvc\\.method\\.annotation\\.ServletInvocableHandlerMethod\\.invokeAndHandle\\(ServletInvocableHandlerMethod\\.java:106\\) ~\\[spring-webmvc-5\\.3\\.3\\.jar:5\\.3\\.3\\]\\n\tat org\\.springframework\\.web\\.servlet\\.mvc\\.method\\.annotation\\.\\.\\(RequestMappingHandlerAdapter\\.java:894\\) ~\\[spring-webmvc-5\\.3\\.3\\.jar:5\\.3\\.3\\]\\n\tat org\\.springframework\\.web\\.servlet\\.mvc\\.method\\.annotation\\.RequestMappingHandlerAdapter\\.handleInternal\\(RequestMappingHandlerAdapter\\.java:808\\) ~\\[spring-webmvc-5\\.3\\.3\\.jar:5\\.3\\.3\\]\\n\tat org\\.springframework\\.web\\.servlet\\.mvc\\.method\\.AbstractHandlerMethodAdapter\\.handle\\(AbstractHandlerMethodAdapter\\.java:87\\) ~\\[spring-webmvc-5\\.3\\.3\\.jar:5\\.3\\.3\\]\\n\tat org\\.springframework\\.web\\.servlet\\.DispatcherServlet\\.doDispatch\\(DispatcherServlet\\.java:1060\\) ~\\[spring-webmvc-5\\.3\\.3\\.jar:5\\.3\\.3\\]\\n\tat org\\.springframework\\.web\\.servlet\\.DispatcherServlet\\.doService\\(DispatcherServlet\\.java:962\\) ~\\[spring-webmvc-5\\.3\\.3\\.jar:5\\.3\\.3\\]\\n\tat org\\.springframework\\.web\\.servlet\\.FrameworkServlet\\.processRequest\\(FrameworkServlet\\.java:1006\\) ~\\[spring-webmvc-5\\.3\\.3\\.jar:5\\.3\\.3\\]\\n\tat org\\.springframework\\.web\\.servlet\\.FrameworkServlet\\.doGet\\(FrameworkServlet\\.java:898\\) ~\\[spring-webmvc-5\\.3\\.3\\.jar:5\\.3\\.3\\]\\n\tat javax\\.servlet\\.http\\.HttpServlet\\.service\\(HttpServlet\\.java:645\\) ~\\[javax\\.servlet-api-4\\.0\\.1\\.jar:4\\.0\\.1\\]\\n\tat org\\.springframework\\.web\\.servlet\\.FrameworkServlet\\.service\\(FrameworkServlet\\.java:883\\) ~\\[spring-webmvc-5\\.3\\.3\\.jar:5\\.3\\.3\\]\\n\tat javax\\.servlet\\.http\\.HttpServlet\\.service\\(HttpServlet\\.java:750\\) ~\\[javax\\.servlet-api-4\\.0\\.1\\.jar:4\\.0\\.1\\]\\n\tat org\\.apache\\.catalina\\.core\\.ApplicationFilterChain\\.internalDoFilter\\(ApplicationFilterChain\\.java:231\\) ~\\[tomcat-embed-core-9\\.0\\.41\\.jar:9\\.0\\.41\\]\\n\tat org\\.apache\\.catalina\\.core\\.ApplicationFilterChain\\.doFilter\\(ApplicationFilterChain\\.java:166\\) ~\\[tomcat-embed-core-9\\.0\\.41\\.jar:9\\.0\\.41\\]\\n\tat org\\.apache\\.tomcat\\.websocket\\.server\\.WsFilter\\.doFilter\\(WsFilter\\.java:53\\) ~\\[tomcat-embed-websocket-9\\.0\\.41\\.jar:9\\.0\\.41\\]\\n\tat org\\.apache\\.catalina\\.core\\.ApplicationFilterChain\\.internalDoFilter\\(ApplicationFilterChain\\.java:193\\) ~\\[tomcat-embed-core-9\\.0\\.41\\.jar:9\\.0\\.41\\]\\n\tat org\\.apache\\.catalina\\.core\\.ApplicationFilterChain\\.doFilter\\(ApplicationFilterChain\\.java:166\\) ~\\[tomcat-embed-core-9\\.0\\.41\\.jar:9\\.0\\.41\\]\\n\tat org\\.springframework\\.web\\.filter\\.OncePerRequestFilter\\.doFilter\\(OncePerRequestFilter\\.java:119\\) ~\\[spring-web-5\\.3\\.3\\.jar:5\\.3\\.3\\]\\n\tat org\\.apache\\.catalina\\.core\\.ApplicationFilterChain\\.internalDoFilter\\(ApplicationFilterChain\\.java:193\\) ~\\[tomcat-embed-core-9\\.0\\.41\\.jar:9\\.0\\.41\\]\\n\tat org\\.apache\\.catalina\\.core\\.ApplicationFilterChain\\.doFilter\\(ApplicationFilterChain\\.java:166\\) ~\\[tomcat-embed-core-9\\.0\\.41\\.jar:9\\.0\\.41\\]\\n\tat org\\.apache\\.catalina\\.core\\.ApplicationFilterChain\\.internalDoFilter\\(ApplicationFilterChain\\.java:193\\) ~\\[tomcat-embed-core-9\\.0\\.41\\.jar:9\\.0\\.41\\]\\n\tat org\\.apache\\.catalina\\.core\\.ApplicationFilterChain\\.doFilter\\(ApplicationFilterChain\\.java:166\\) ~\\[tomcat-embed-core-9\\.0\\.41\\.jar:9\\.0\\.41\\]\\n\tat org\\.springframework\\.web\\.servlet\\.resource\\.ResourceUrlEncodingFilter\\.doFilter\\(ResourceUrlEncodingFilter\\.java:67\\) ~\\[spring-webmvc-5\\.3\\.3\\.jar:5\\.3\\.3\\]\\n\tat org\\.apache\\.catalina\\.core\\.\\.internalDoFilter\\(ApplicationFilterChain\\.java:193\\) ~\\[tomcat-embed-core-9\\.0\\.41\\.jar:9\\.0\\.41\\]\\n\tat org\\.apache\\.catalina\\.core\\.ApplicationFilterChain\\.doFilter\\(ApplicationFilterChain\\.java:166\\) ~\\[tomcat-embed-core-9\\.0\\.41\\.jar:9\\.0\\.41\\]\\n\tat org\\.springframework\\.security\\.web\\.FilterChainProxy\\$VirtualFilterChain\\.doFilter\\(FilterChainProxy\\.java:327\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.springframework\\.security\\.web\\.access\\.intercept\\.FilterSecurityInterceptor\\.invoke\\(FilterSecurityInterceptor\\.java:115\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.springframework\\.security\\.web\\.access\\.intercept\\.FilterSecurityInterceptor\\.doFilter\\(FilterSecurityInterceptor\\.java:81\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.springfamework\\.security\\.web\\.\\$VirtualFilterChain\\.doFilter\\(FilterChainProxy\\.java:336\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.springframework\\.security\\.web\\.access\\.ExceptionTranslationFilter\\.doFilter\\(\\.java:119\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.springframework\\.security\\.web\\.\\.ExceptionTranslationFilter\\.doFilter\\(ExceptionTranslationFilter\\.java:113\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.springframework\\.security\\.web\\.FilterChainProxy\\$VirtualFilterChain\\.doFilter\\(FilterChainProxy\\.java:336\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.springframework\\.security\\.web\\.session\\.SessionManagementFilter\\.doFilter\\(SessionManagementFilter\\.java:126\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.springframework\\.security\\.web\\.session\\.SessionManagementFilter\\.doFilter\\(SessionManagementFilter\\.java:81\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.\\.security\\.web\\.FilterChainProxy\\$VirtualFilterChain\\.doFilter\\(FilterChainProxy\\.java:336\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.springaframework\\.security\\.web\\.authentication\\.AnonymousAuthenticationFilter\\.doFilter\\(AnonymousAuthenticationFilter\\.java:105\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.springframework\\.security\\.web\\.FilterChainProxy\\$VirtualFilterChain\\.doFilter\\(FilterChainProxy\\.java:336\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.springframework\\.security\\.web\\.servletapi\\.SecurityContextHolderAwareRequestFilter\\.doFilter\\(SecurityContextHolderAwareRequestFilter\\.java:149\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.springframework\\.security\\.web\\.FilterChainProxy\\$VirtualFilterChain\\.doFilter\\(FilterChainProxy\\.java:336\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.springframework\\.security\\.web\\.savedrequest\\.RequestCacheAwareFilter\\.doFilter\\(RequestCacheAwareFilter\\.java:63\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.springframework\\.security\\.web\\.\\$VirtualFilterChain\\.doFilter\\(FilterChainProxy\\.java:336\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.\\.security\\.web\\.authentication\\.www\\.BasicAuthenticationFilter\\.doFilterInternal\\(BasicAuthenticationFilter\\.java:149\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.springframework\\.web\\.filter\\.\\.doFilter\\(OncePerRequestFilter\\.java:119\\) ~\\[spring-web-5\\.3\\.3\\.jar:5\\.3\\.3\\]\\n\tat org\\.springframewDefaultLogoutPageGeneratingFilterork\\.security\\.web\\.FilterChainProxy\\$VirtualFilterChain\\.doFilter\\(FilterChainProxy\\.java:336\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.springframework\\.security\\.web\\.authentication\\.ui\\.DefaultLogoutPageGeneratingFilter\\.doFilterInternal\\(DefaultLogoutPageGeDeDDefalerefaaaultLogoutPageGeneratingFilterfaultLogoutPageGeneratingFilterneratingFilterDefaultLogoutPageGeneratingFilter\\.java:58\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.springframework\\.web\\.filter\\.\\.doFilter\\(OncePerRequestFilter\\.java:119\\) ~\\[spring-web-5\\.3\\.3\\.jar:5\\.3\\.3\\]\\n\tat org\\.springframework\\.security\\.web\\.FilterChainProxy\\$VirtualFilterChain\\.doFilter\\(FilterChainProxy\\.java:336\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.\\.security\\.web\\.authentication\\.ui\\.DefaultLoginPageGeneratingFilter\\.doFilter\\(DefaultLoginPageGeneratingFilter\\.java:237\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.springframework\\.security\\.web\\.authentication\\.ui\\.DefaultLoginPageGeneratingFilter\\.doFilter\\(DefaultLoginPageGeneratingFilter\\.java:223\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.springframework\\.security\\.web\\.FilterChainProxy\\$VirtualFilterChain\\.doFilter\\(FilterChainProxy\\.java:336\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.springframework\\.security\\.web\\.authentication\\.AbstractAuthenticationProcessingFilter\\.doFilter\\(AbstractAuthenticationProcessingFilter\\.java:218\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.springframework\\.security\\.web\\.authentication\\.AbstractAuthenticationProcessingFilter\\.doFilter\\(AbstractAuthenticationProcessingFilter\\.java:212\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.springframework\\.security\\.web\\.FilterChainProxy\\$VirtualFilterChain\\.doFilter\\(FilterChainProxy\\.java:336\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.springframework\\.security\\.web\\.authentication\\.logout\\.LogoutFilter\\.doFilter\\(LogoutFilter\\.java:103\\) ~\\[spring-security-web-5\\.4\\.2\\.jar:5\\.4\\.2\\]\\n\tat org\\.springf", 'gimu').exec('test')

When deleting a single character of any identifier in the regex source, the error is not being thrown anymore.

I guess the rule when a regex is too large is rather complex.

[alexdima]

Given this is native v8 / JS behavior, this is a limitation that we will have to live with. We want to keep using JS regexes for searching.