Skip to content

Closing terminal with zsh exit status prompts error #121323

@sdegutis

Description

@sdegutis

Issue Type: Bug

When I have an error in zsh like from rm doesnt-exist, and I close the terminal via zsh (ctrl-d or exit), VS Code shows:

"The terminal process "/bin/zsh '-l'" terminated with exit code: 1."
[ Open Help ]

And that's just not helpful. I'm not sure when it ever is? It makes sense when the shell itself crashes, but zsh seems to propagate the last command's error to its own caller, which in this case means I often get this message. Please make it stop.

VS Code version: Code 1.55.2 (3c4e3df, 2021-04-13T09:36:32.643Z)
OS version: Darwin x64 19.6.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-3740QM CPU @ 2.70GHz (8 x 2700)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 3, 3
Memory (System) 16.00GB (3.30GB free)
Process Argv -psn_0_5334294 --crash-reporter-id aa77e851-0fc5-45a8-b2b6-6d32c4e1f3ee
Screen Reader no
VM 0%
Extensions (6)
Extension Author (truncated) Version
vscode-sqlite ale 0.12.0
rainbow-csv mec 1.8.1
dotenv mik 1.0.1
vscode-js-profile-flame ms- 0.0.15
material-icon-theme PKi 4.6.0
rewrap stk 1.14.0
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstry244:30276681
pythonvsdeb440:30248342
pythonvsded773:30248341
pythonvspyt875:30259475
pythonvsnew554cf:30281909
pythontb:30283811
wslfolderdoc:30282074
vspre833:30267464
pythonptprofiler:30281270
vshan820:30276952
pythondataviewer:30285071
vscus158:30286553

Metadata

Metadata

Labels

*as-designedDescribed behavior is as designedterminalGeneral terminal issues that don't fall under another label

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions