List does not show which element is focused when custom context menu is shown

[gtteamamxx]

I can imagine situations where someone missed right-click and deleted other file than wanted to.
To avoid this situation we can set border. Like when file is focused:

[isidorn]

Yes, this is the problem with List / Tree in general with the Custom menu and I can reproduce. Thus forwarding to @joaomoreno
It seems like the focus border is only rendered when the focus is on the list, and the native context menu "steal focus"

This works nicely on macOS with native menus.
fyi @sbatten

[joaomoreno]

I have always argued for this and somehow got lost over time. I even went to great lengths to make this work in dropdown menus. Unfortunately, the list/tree doesn't know about context menus. It seems like maybe it should.

[gtteamamxx]

I'm glad that something will change with this :)

[isidorn]

This is present for all our Web experiences and Windows and I think we should fix sooner or later.
@joaomoreno Should we maybe open this up for PRs if you can provide a code pointer?

[joaomoreno]

@isidorn This is tough to fix.

[sbatten]

@joaomoreno can you leverage

vscode/src/vs/base/browser/contextmenu.ts

Line 31 in 7031aba

domForShadowRoot?: HTMLElement;

?

[joaomoreno]

@sbatten What do you mean?

This is hard to fix because:

• List focus indicators are supposed to be invisible when the list (or the app) doesn't have focus
• When a context menu comes up, it takes focus by definition, so the list focus affordance gets hidden
• For this to work, the list would need to be aware that there's a context menu open related to itself. But the list doesn't know anything about context menus: they are a construct of the list's users.

[sbatten]

I don't know how the context menus are created but if whoever creates the context menu knows the selected list item at the time, it could be used as the parent of the context menu in a shadow dom to preserve focus. this is how dropdowns work in view actions where they disappear on focus lost.