vscode.executeDocumentRenameProvider command gives error for virtual document

[william-xiang]

We are trying to support embedded SQL in the main language using request forwarding. For now we already did this for completion and hover, but have some trouble with rename. The problem is the snippet below always gives us this error:
Running the contributed command: 'vscode.executeDocumentRenameProvider' failed. It seems like the reason is that the document is not opened in the editor.

provideRenameEdits: async (document, position, newName, token, next) => {
    const vdocUri = this.getVirtualDocumentUri(document);
    return await commands.executeCommand<WorkspaceEdit>('vscode.executeDocumentRenameProvider', vdocUri, position, newName);
}

Is there any way to support rename for virtual document?

---

VS Code version: 1.56.2
vscode-languageclient: 7.0.0

[dbaeumer]

@william-xiang I move this to VS Code since it is not related to LSP.

[jrieken]

It seems like the reason is that the document is not opened in the editor.

I don't believe so - the command will open the document for rename (tho not show it in an editor). The error is likely because the underlying language extension to which you are delegating doesn't support the virtual document. Tho, you need to check the logs for more info

[william-xiang]

It seems like the reason is that the document is not opened in the editor.

I don't believe so - the command will open the document for rename (tho not show it in an editor). The error is likely because the underlying language extension to which you are delegating doesn't support the virtual document. Tho, you need to check the logs for more info

Thanks for the reply, @jrieken. Unfortunately, it does not give me any info in the log regarding this. When I debug it, got this exception info:

Exception has occurred: Error: Running the contributed command: 'vscode.executeDocumentRenameProvider' failed.
t E._executeContributedCommand (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:87:108092) at processTicksAndRejections (internal/process/task_queues.js:93:5)

By the way, do I need to do something on server side to support virtual document? Completion and hover work for virtual document without doing anything special on server side.

[vscode-triage-bot]

Hey @jrieken, this issue might need further attention.

@william-xiang, you can help us out by closing this issue if the problem no longer exists, or adding more information.