TaskPresentationOptions.focus = false is not honored when the terminal is revealed

[matklad]

Does this issue occur when all extensions are disabled?: Yes/No

Version: 1.55.2
Commit: 3c4e3df
Date: 2021-04-13T09:37:02.931Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Linux x64 5.10.32

In rust-analyzer, we are are creating a Task with focus = false in the presentation. However, the terminal window is still focused if the terminal gets revealed. I would expect that the combination of reveal always and focus false results in the editor always keeping focus, even if the terminal needs to be shown in the UI. Here's a video of the wrong behavior.

focus.mp4

Note how the first run of the task steals the focus, but subsequent runs are ok, unless the terminal is closed.

Here's the relevant code from rust-analyzer:

https://github.com/rust-analyzer/rust-analyzer/blob/249e22b3250a6e35d53064decb60b67b42a75f42/editors/code/src/run.ts#L146-L149

[alexr00]

@sbatten the problem appears to be with IViewsService.openView. The terminal is passing in the correct focus value of false, but focus is still happening.

vscode/src/vs/workbench/contrib/terminal/browser/terminalService.ts

Lines 826 to 827 in 29cad8f

	await this._viewsService.openView(TERMINAL_VIEW_ID, focus);
	}

To repro:

1. Open a folder with a task in it. The extension samples are great for this.
2. Set the task's presentation options. Example:

        {
            "type": "npm",
            "script": "watch",
            "problemMatcher": "$tsc-watch",
            "isBackground": true,
            "presentation": {
                "focus": false // This is the important line
            },
            "group": {
                "kind": "build",
                "isDefault": true
            }
        }

3. Open a view in the panel that is not the terminal.
4. Put focus in the editor.
5. Run the task. If you have the usual keybinding and your task is a build task as in step 2, then you can to ctrl+shift+b.
6. See that the terminal gets focused.

[alexr00]

@sbatten just a ping to make sure you've seen this one :)

[sbatten]

@meganrogge I tried reproing this by changing the focus terminal command to pass focus:false to the showView method. Unfortunately it seems the terminal always steals focus when it becomes visible.

vscode/src/vs/workbench/contrib/terminal/browser/terminalView.ts

Line 150 in bc4d780

this._terminalGroupService.showPanel(true);