Bring back onDidCloseNotebookDocument

[tanhakabir]

Some notebooks like the Kusto Notebooks depends on onDidCloseNotebookDocument to clean up any connections and dispose of anything important for the Notebook opened.

This isn't possible now and the closest workaround is to use onDidSaveNotebookDocument and maybe in the extension deactivate function to do any leftover clean up which isn't ideal.

[vscode-triage-bot]

Pinging notebook topic followers: @claudiaregio @rchiodo @greazer @DonJayamanne @jilljac @IanMatthewHuff

[DonJayamanne]

I think the Kusto notebooks extension hasn't been updated to use the latest API.

[tanhakabir]

@DonJayamanne I was working on that now

[jrieken]

It's not gone, it has been moved to the workspace namespace: vscode.workspace.onDidCloseNotebookDocument