Terminal "local echo" leaks confidential inputs #128530
Description
Issue Type: Bug
Back in 1.51, a new feature called Local Echo was introduced.
This behavior leaks confidential keyboard inputs that would otherwise be hidden from observers.
To reproduce, just run any command with sudo. In a local shell, this would not produce any output while entering the user's password. With local echo, all pressed keys are clearly visible on screen.
VS Code version: Code 1.58.0 (2d23c42, 2021-07-08T06:54:55.083Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No
Remote OS version: Linux x64 5.4.72-microsoft-standard-WSL2
Remote OS version: Linux x64 5.4.72-microsoft-standard-WSL2
System Info
| Item | Value |
|---|---|
| CPUs | Intel(R) Core(TM) i7-6850K CPU @ 3.60GHz (12 x 3592) |
| GPU Status | 2d_canvas: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on rasterization: enabled skia_renderer: enabled_on video_decode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled |
| Load (avg) | undefined |
| Memory (System) | 63.87GB (20.06GB free) |
| Process Argv | --crash-reporter-id 05565d81-cfc4-40de-88df-1c479bbe1bcd |
| Screen Reader | no |
| VM | 0% |
| Item | Value |
|---|---|
| Remote | WSL: Ubuntu |
| OS | Linux x64 5.4.72-microsoft-standard-WSL2 |
| CPUs | Intel(R) Core(TM) i7-6850K CPU @ 3.60GHz (12 x 3591) |
| Memory (System) | 50.11GB (15.49GB free) |
| VM | 0% |
| Item | Value |
|---|---|
| Remote | WSL: Ubuntu |
| OS | Linux x64 5.4.72-microsoft-standard-WSL2 |
| CPUs | Intel(R) Core(TM) i7-6850K CPU @ 3.60GHz (12 x 3591) |
| Memory (System) | 50.11GB (15.51GB free) |
| VM | 0% |
Extensions (30)
| Extension | Author (truncated) | Version |
|---|---|---|
| javascript-ejs-support | Dig | 1.3.1 |
| eslint-disable-snippets | drK | 1.3.0 |
| tsl-problem-matcher | eam | 0.4.0 |
| output-colorizer | IBM | 0.1.2 |
| remote-containers | ms- | 0.187.0 |
| remote-ssh | ms- | 0.65.7 |
| remote-ssh-edit | ms- | 0.65.7 |
| remote-wsl | ms- | 0.58.2 |
| vscode-remote-extensionpack | ms- | 0.21.0 |
| vscode-icons | vsc | 11.5.0 |
| vscode-zipfs | arc | 2.3.0 |
| better-toml | bun | 0.3.2 |
| vscode-eslint | dba | 2.1.23 |
| xml | Dot | 2.5.1 |
| EditorConfig | Edi | 0.16.4 |
| prettier-vscode | esb | 8.0.1 |
| generateuuid | Fir | 0.0.5 |
| shell-format | fox | 7.1.0 |
| vscode-graphql | Gra | 0.3.16 |
| yarn2-dependency-explorer | hah | 0.0.1 |
| terraform | has | 2.13.0 |
| vscode-esformatter | how | 1.6.0 |
| vscode-random | jre | 1.9.0 |
| template-string-converter | meg | 0.5.0 |
| vscode-docker | ms- | 1.14.0 |
| python | ms- | 2021.6.944021595 |
| vscode-pylance | ms- | 2021.7.2 |
| jupyter | ms- | 2021.8.1013163132 |
| vscode-paste-image | mus | 1.0.4 |
| monolit | Oli | 0.0.33 |
(1 theme extensions excluded)