Upstream pevents changes, early testing or feedback requested

[mqudsi]

Hello team,

I'm the author of pevents, the WIN32 manual/auto-reset events library for Linux. To my knowledge, VS Code is (or was) one of the bigger projects depending on pevents; iirc it was used in some of the language-specific extensions.

There's a fairly large change that's been finalized and is ready for merging into master, but I was wondering if someone from the team working on the extensions that use pevents could get in touch. Presumably your project has some LSP unit/integration tests that cover multithreaded synchronization; it would be great if I could get an all-ok that everything continues to work fine with the latest changes. Given the nature of multithreaded code (especially with optimizations enabled) it's extremely tricky to validate architectural changes to synchronization primitives, even with all the unit and regression tests passing on our end. Having further real-world verification would be great, and in case any issues arise, hopefully it would be better than you guys updating to master and having your production release randomly fail.

[dbaeumer]

I checked our code base and the yarn.lock and couldn't find any reference to pevents.

@bpasero assigning to you since you usually know more about use using native libraries. Feel free to close if my investigation was correct.

[bpasero]

This is the first time I hear about the library, so moving back to you to decide whether an action is needed on our end.

[mqudsi]

I think it was in vscode-cpptools, see sample stack trace from macOS below (this is not recent):

0   libsystem_kernel.dylib        	0x00007fff6a67186a __psynch_cvwait + 10
1   libsystem_pthread.dylib       	0x00007fff6a73056e _pthread_cond_wait + 722
2   Microsoft.VSCode.CPP.IntelliSense.Msvc.darwin	0x0000000100401d6c neosmart::WaitForMultipleEvents(neosmart::neosmart_event_t_**, int, bool, unsigned long long, int&) + 1180
3   Microsoft.VSCode.CPP.IntelliSense.Msvc.darwin	0x00000001003ffc45 msvc::alertable_event::wait_for_multiple(msvc::alertable_event**, unsigned long, bool, unsigned int) + 325
4   Microsoft.VSCode.CPP.IntelliSense.Msvc.darwin	0x0000000100400396 async_pipe_nix::read_thread_proc() + 406
5   Microsoft.VSCode.CPP.IntelliSense.Msvc.darwin	0x0000000100400f0d void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, async_pipe_nix::ensure_read_thread()::$_0> >(void*) + 45
6   libsystem_pthread.dylib       	0x00007fff6a72d2eb _pthread_body + 126
7   libsystem_pthread.dylib       	0x00007fff6a730249 _pthread_start + 66
8   libsystem_pthread.dylib       	0x00007fff6a72c40d thread_start + 13

[dbaeumer]

@sean-mcmanus FYI.

I will close the issue since VS Code core is not using the library.

[mqudsi]

Sorry, I didn't realize it wasn't a monorepo. Can you move this to https://github.com/microsoft/vscode-cpptools and reopen?

[dbaeumer]

@mqudsi I tried but I couldn't. Surprisingly I don't have rights to move it there :-(.