Consider disallowing importing `workbench/api/~` in `workbench/services/~`

[alexdima]

ref #140874

• comment out

  vscode/.eslintrc.json

  Line 264 in 71b164a

  "vs/workbench/api/~",

• run yarn eslint

Most errors come from the extension host process being implemented in workbench/services/extensions/**. If we'd implement the extension host process somewhere else, we might be close to disallowing workbench/api/~ in workbench/services/~.

cc @jrieken @bpasero

vs/workbench/services/authentication/browser/authenticationService.ts: line 26, col 50
vs/workbench/services/extensions/browser/webWorkerExtensionHost.ts: line 11, col 35
vs/workbench/services/extensions/common/abstractExtensionService.ts: line 27, col 43
vs/workbench/services/extensions/common/abstractExtensionService.ts: line 29, col 140
vs/workbench/services/extensions/common/extensionHostMain.ts: line 13, col 64
vs/workbench/services/extensions/common/extensionHostMain.ts: line 19, col 41
vs/workbench/services/extensions/common/extensionHostMain.ts: line 22, col 55
vs/workbench/services/extensions/common/extensionHostMain.ts: line 23, col 63
vs/workbench/services/extensions/common/extensionHostMain.ts: line 24, col 54
vs/workbench/services/extensions/common/extensionHostMain.ts: line 25, col 41
vs/workbench/services/extensions/common/extensionHostManager.ts: line 12, col 42
vs/workbench/services/extensions/common/extensionHostManager.ts: line 13, col 92
vs/workbench/services/extensions/common/extensionHostManager.ts: line 24, col 43
vs/workbench/services/extensions/common/extensions.ts: line 14, col 43
vs/workbench/services/extensions/common/remoteExtensionHost.ts: line 27, col 35
vs/workbench/services/extensions/electron-browser/localProcessExtensionHost.ts: line 32, col 35
vs/workbench/services/extensions/node/extensionHostProcessSetup.ts: line 16, col 27
vs/workbench/services/extensions/node/extensionHostProcessSetup.ts: line 23, col 28
vs/workbench/services/extensions/node/extensionHostProcessSetup.ts: line 27, col 8
vs/workbench/services/extensions/node/extensionHostProcessSetup.ts: line 28, col 8
vs/workbench/services/extensions/node/proxyResolver.ts: line 10, col 43
vs/workbench/services/extensions/node/proxyResolver.ts: line 11, col 39
vs/workbench/services/extensions/node/proxyResolver.ts: line 12, col 53
vs/workbench/services/extensions/node/proxyResolver.ts: line 13, col 41
vs/workbench/services/extensions/worker/extensionHostWorker.ts: line 10, col 27
vs/workbench/services/extensions/worker/extensionHostWorker.ts: line 12, col 28
vs/workbench/services/extensions/worker/extensionHostWorker.ts: line 17, col 8
vs/workbench/services/extensions/worker/extensionHostWorker.ts: line 18, col 8
vs/workbench/services/keybinding/browser/keybindingService.ts: line 37, col 40

[bpasero]

Yup 👍 , also felt there could be a better place outside that folder. Though we might be missing a concept for where to put it unless we want to introduce another top level folder for extension host (and maybe API?).