Skip to content

Look into usage of FileSystemDirectoryHandle in localFileSearchWorkerTypes.ts #141033

@mjbvz

Description

@mjbvz

In https://github.com/microsoft/vscode/blob/7b4fd0b65bc0ab6b919cacd833db312e9c05b85f/src/vs/workbench/services/search/common/localFileSearchWorkerTypes.ts I see FileSystemDirectoryHandle is used a few times.

I believe this type comes from the dom, although we pull it in from types/wicg-file-system-access. However the newest TS nightlies actually move it into lib.dom.d.ts. This causes an hygiene error because a file in common now references something from the dom

@JacksonKearl Can you please investigate moving this type out of common so we can update our TS version

Metadata

Metadata

Assignees

Labels

engineeringVS Code - Build / issue tracking / etc.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions