No code action for XX when XX is associated to a Command and not a WorkspaceEdit

[lrnv]

Issue Type: Bug

Hi,

This is a followup to valentjn/vscode-ltex#363 (comment).
It seems like putting the following in keybindings.json:

[
    {
      "key": "ctrl+shift+q",
      "command": "editor.action.codeAction",
      "args": {
        "kind": "quickfix.ltex.acceptSuggestions"
      }
    },
    {
      "key": "ctrl+shift+d",
      "command": "editor.action.codeAction",
      "args": {
        "kind": "quickfix.ltex.addToDictionary"
      }
    }
]

does work for acceptSuggestions, which is a code action associated to a WorkspaceEdit, and does not for addToDictionary, which is a code action associated to a Command, and produce the No code action for quickfix.ltex.addToDistionary available popup when hit. According to @valentjn, this seems to be a bug of VS Code:

I think that's a bug in VS Code. The difference between acceptSuggestions and the other kinds of quick fixes is that the code action corresponding to acceptSuggestions is associated to a WorkspaceEdit, but the others are associated to a Command. However, I don't see a reason why VS Code shouldn't be able to run those quick fixes, too. Please refer to microsoft/vscode for this.

Thoughts ?

VS Code version: Code - Insiders 1.65.0-insider (0283cec, 2022-02-08T05:16:42.414Z)
OS version: Windows_NT x64 10.0.19042
Restricted Mode: No

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2112)
GPU Status	2d_canvas: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on rasterization: enabled skia_renderer: enabled_on video_decode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	15.88GB (6.90GB free)
Process Argv	--folder-uri file:///c%3A/Users/u009192/Documents/project_ggchd/ggchd_paper --crash-reporter-id ba05d066-2a4b-4588-a50c-4c80808f45e6
Screen Reader	no
VM	0%

Extensions (3)

Extension	Author (truncated)	Version
vscode-pull-request-github	Git	0.36.1
latex-workshop	Jam	8.23.0
vscode-ltex	val	13.1.0

[mjbvz]

Please share a minimal extension sample that demonstrates what you think the issue is

[lrnv]

I do not now what you mean by a minimal extension sample, but I can tell you that the following actions reproduces the issue :

• Open a new folder in VSCode, and add the upper code in the keybindings.json.
• Install the LTeX extension
• Open a new file, set its language to markdown (or name it file.md), with the following content :

This is a sentences in a file, with a typo in it. 
This is a second sentence, with a new unknown WordToAddToDistionary. 

You'll see that the words a sentences and WordToAddToDictionary are both underlined by LTeX. On the first one, you can use ctrl+shit+q to activate the quickfix.ltex.acceptSuggestions, which would work.
On the second one, ctrl+shift+d will NOT launch quickfix.ltex.addToDictionary, but instead provide a popup that says :

No code action for `quickfix.ltex.addToDictionary` available

@mjbvz, is that enough of a reproducible exemple ?

[mjbvz]

Please put together a small extension that demonstrates the issue. Testing with full LaTeX extension takes a lot of time because we have to figure out what that extension is doing and if it's the root cause or if VS Code is causing problems

You can build on the code actions sample: https://github.com/microsoft/vscode-extension-samples/tree/main/code-actions-sample

[vscode-triage-bot]

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

[lrnv]

Sorry but I do not have the skills to put together another extension that will show off the problem. My description however is quite fair, several people experienced the same issue (see OP and links therein), and it is easy to reproduce. I do not understand why this is not enough to declare it a bug.

The bug was already reported at the extension level, where @valentjn said to come here, and here you say it's the extension's problem ? The code generating the bug is explicitly pointed in OP.