Window position gets messed up when you open a text file from terminal in Linux

[steel-steven-87]

Does this issue occur when all extensions are disabled?: Yes (clean install of vscode on a clean install of Kubuntu)

Version: 1.65.0 (can also be reproduced in 1.66.0-insider)
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Linux x64 5.13.0-30-generic snap (Kubuntu 21.04)

Steps to Reproduce:

1. Open VSCode.
2. Maximize the window.
3. Minimize the window.
4. Open a file from inside of a terminal, e.g. code test.txt.

The window gets restored, but it is not maximized anymore. Window position and size gets messed up randomly.

[bpasero]

/gifPlease

[vscode-triage-bot]

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.

If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette).

Happy coding!

[steel-steven-87]

Attaching a recording. You can see that the window was maximized, but when you open a file, it is not maximized anymore. You have to maximize the window every time you open a new file.

[bpasero]

Does the same happen when you click on the icon in the task bar after the window is minimized?

[steel-steven-87]

Does the same happen when you click on the icon in the task bar after the window is minimized?

It doesn't happen when you click the icon to restore the window.

The position gets messed up only when you open a file. This also happens if you have a file association to open text files with VSCode and double click on a file. So, this affects the daily use of VSCode since any file you open will unmaximize the window.

[bpasero]

This sounds like an Electron issue to me, in the end we simply call this method to make sure the window has focus:

vscode/src/vs/platform/windows/electron-main/window.ts

Lines 341 to 362 in e9f5380

	focus(options?: { force: boolean }): void {
	// macOS: Electron > 7.x changed its behaviour to not
	// bring the application to the foreground when a window
	// is focused programmatically. Only via `app.focus` and
	// the option `steal: true` can you get the previous
	// behaviour back. The only reason to use this option is
	// when a window is getting focused while the application
	// is not in the foreground.
	if (isMacintosh && options?.force) {
	app.focus({ steal: true });
	}
	if (!this._win) {
	return;
	}
	if (this._win.isMinimized()) {
	this._win.restore();
	}
	this._win.focus();
	}

@deepak1556 any advice?

[bpasero]

I think this._win.restore(); does the wrong thing then and does not preserve the maximized bit.

[vscode-triage-bot]

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!