QuickInput error aligns weirdly

[isidorn]

Testing #145626

Notice how the quick input validation message aligns weirdly with the rest of quick input:

1. It overwrites the placeholder text to "Accept on enter..."
2. It goes below the quick input

It feels like it was just stuck on top of the existing quick input UI. I would love it feel a bit more native in the quick input.

[TylerLeonhardt]

@isidorn so before, it would cause the quickpick to grow... and someone opened an issue saying that looked weird. I think it was @bpasero.

Even though it goes below the quick input, I think the layering looks fine because of the thick border.

I would love it feel a bit more native in the quick input.

what would this look like in your opinion?

[bpasero]

Yeah I am not a big fan of how it was and how it is now but find the current behaviour better :)

[isidorn]

It would feel more native as if the dimensions were aligned with the quick pick dimensions, and it was not going outside of it.

I think it is fine as it is... So feel free to leave it. Or if you would like to polish then maybe we can ping the design team for help.

[TylerLeonhardt]

@misolori do you have thoughts about this?

[miguelsolorio]

We could alternately use the quick pick entries to highlight the error instead? Though that would be a new pattern for errors:

Similarly used:

[isidorn]

@misolori this looks great but more aligned with the QuickPick UI. But I wonder if the message is multi line?

[TylerLeonhardt]

Yeah today the "No matching results" part can't be multi-line:

However, I think there's more to discuss here... one of the problems I have with the current experience is that the error covers the prompt. So if you forget the prompt, you have to mutate the input to stop showing the error to see what you actually need to input.

I think we need to step back and put the error somewhere less disruptive. Asking questions out loud:

• Does the error maybe push the prompt down? might make the prompt too jumpy
• Does the error go underneath the prompt? might make the error too disconnected
• Does the error go to the right? quick pick isn't really wide enough for that
• Does the error go above? this might cause the whole input/prompt to get pushed down so again too jumpy
• Do we go the squiggles route similar to the editor? might not be in the users face enough

[TylerLeonhardt]

Another one for @daviddossett to think about maybe? Also seems applicable to other quick pick/command center stuff.