Skip to content

tabGroups.close promise resolves immediately instead of after user confirmation #145828

@JacksonKearl

Description

@JacksonKearl

Testing #145585

With a dirty editor and autosave off, running this code will resolve the close and print the result while the editor is still open and the user is prompted for whether to save it. It might make sense to only resolve the promise after that, and perhaps return a boolean for whether the editor was closed.

const result = await vscode.window.tabGroups.close(active);
console.log('hello result', { result });

Metadata

Metadata

Assignees

Labels

apifeature-requestRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code Insidersverification-neededVerification of issue is requestedverifiedVerification succeededworkbench-tabsVS Code editor tab issues

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions