Terminal UI issue with new Light High Contrast Theme

[vish-sn]

Issue Type: Bug

Hi,

I am like the Light HIgh Constrast Theme very much. But, noticed followign bug.

When I use the new Light High Contrast Theme. The VSCode terminal does not show highlighted text. I can highlight the text and copy it but there is no visual hint on what text I highlighted.

Thanks,
Vish

VS Code version: Code 1.65.2 (Universal) (c722ca6, 2022-03-10T14:33:49.188Z)
OS version: Darwin x64 20.6.0
Restricted Mode: No

[meganrogge]

The selection does look quite light

[Tyriar]

Yeah I noticed this as well, moving to @daviddossett who owns the theme

[daviddossett]

Yeah, this is a known issue. There's actually a similar, perhaps slightly less problematic contrast issue with the existing Dark HC theme:

I think we need something like TERMINAL_SELECTION_FOREGROUND_COLOR to pair with this existing token:

vscode/src/vs/workbench/contrib/terminal/common/terminalColorRegistry.ts

Lines 26 to 31 in fa2d19c

	export const TERMINAL_SELECTION_BACKGROUND_COLOR = registerColor('terminal.selectionBackground', {
	light: '#00000040',
	dark: '#FFFFFF40',
	hcDark: '#FFFFFF80',
	hcLight: '#F2F2F2'
	}, nls.localize('terminal.selectionBackground', 'The selection background color of the terminal.'));

Similar to:

vscode/src/vs/platform/theme/common/colorRegistry.ts

Line 346 in cb3c811

export const editorSelectionForeground = registerColor('editor.selectionForeground', { light: null, dark: null, hcDark: '#000000', hcLight: Color.white }, nls.localize('editorSelectionForeground', "Color of the selected text for high contrast."));

Thoughts @Tyriar @meganrogge?