Skip to content

Pass in height to render for list (PR for release/1.66) #146287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rzhao271 wants to merge 1 commit into from
Closed

Pass in height to render for list (PR for release/1.66) #146287

rzhao271 wants to merge 1 commit into from

Conversation

@rzhao271
Copy link
Collaborator

@rzhao271 rzhao271 commented Mar 30, 2022

Fixes #146285

Screencap demo

@rzhao271 rzhao271 added the candidate Issue identified as probable candidate for fixing in the next release label Mar 30, 2022
@rzhao271 rzhao271 added this to the March 2022 milestone Mar 30, 2022
@rzhao271 rzhao271 self-assigned this Mar 30, 2022
@rzhao271 rzhao271 changed the title Pass in height to render for list Pass in height to render for list (PR for release/1.66) Mar 30, 2022
@joaomoreno joaomoreno mentioned this pull request Mar 30, 2022
Merged
joaomoreno
joaomoreno reviewed Mar 30, 2022
View reviewed changes
Copy link
Member

@joaomoreno joaomoreno left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we go with #146307 instead, explanation in #146306 (comment).

@rzhao271 rzhao271 closed this Mar 30, 2022
@rzhao271 rzhao271 deleted the rzhao271/render-height-release branch March 30, 2022 17:58
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joaomoreno joaomoreno joaomoreno left review comments

@roblourens roblourens Awaiting requested review from roblourens

Assignees

@rzhao271 rzhao271

Labels

candidate Issue identified as probable candidate for fixing in the next release

Projects

None yet

Milestone

March 2022 Recovery

Development

Successfully merging this pull request may close these issues.

4 participants

@rzhao271 @joaomoreno @dbaeumer