Linux: Crash dialog does not allow to reopen

[roblourens]

Testing #147699

This is a little funky on my Linux vms. On one of them, if I don't check the "don't restore editors" box and click "reopen", the window never reopens. It works as expected if I check "don't restore editors".

On the other, there is no "don't reload editors" checkbox, and "reopen" never reloads the window.

[bpasero]

This is a tougher one, I believe there are actually 2 crashes happening: one from process.crash() and the other from our handling and I think the second one takes down the entire application.

@deepak1556 can you check the dump files we get when this happens? To reproduce:

• on Linux run with providing --crash-reporter-directory
• run out of sources
• open devtools
• process.crash()
• click Reopen or Close, both will produce a second dmp file

First dmp (probably from process.crash):

4953a25f-53a0-4d79-a084-ea019260a09d.dmp.zip

Second dmp (when clicking "Close" or "Reopen"):
7f77b438-deba-4c4d-a09a-9bca9fdc0e44.dmp.zip

[deepak1556]

First dmp (probably from process.crash):

Yup that is correct.

Second dmp (when clicking "Close" or "Reopen"):

Crash reason:  SIGSEGV /SEGV_MAPERR
Crash address: 0x0
Process uptime: 55 seconds

Thread 0 (crashed)
 0  code-oss!views::DesktopNativeWidgetAura::HandleActivationChanged(bool) [desktop_native_widget_aura.cc : 460 + 0x0]
     x0 = 0x0000000000000000    x1 = 0x0000aaaab2e85408
     x2 = 0x0000000000000001    x3 = 0x0000aaaaaf7fa85c
     x4 = 0x0000000000000001    x5 = 0x0000ffffbb3edf10
     x6 = 0x0000ffffbb3edf10    x7 = 0x0000000000000000
     x8 = 0x0000000000000000    x9 = 0x0000000000000001
    x10 = 0x0000000000218abc   x11 = 0xcccccccccccccccd
    x12 = 0x000000000000000f   x13 = 0x0000000000000002
    x14 = 0x0000000008002239   x15 = 0x0000000008002239
    x16 = 0x0000000000000001   x17 = 0x0000ffffbdfba5a0
    x18 = 0x0000001908242c24   x19 = 0x0000000000000001
    x20 = 0x00000022015f07c0   x21 = 0x0000002200e12cc0
    x22 = 0x0000002200c6e3c0   x23 = 0x0000002201a2e680
    x24 = 0x0000fffffd40e1a0   x25 = 0x0000002201a24a00
    x26 = 0x0000000000000000   x27 = 0x00000022007f13a0
    x28 = 0x0000fffffd40e2b8    fp = 0x0000fffffd40dd70
     lr = 0x0000aaaab2e846c0    sp = 0x0000fffffd40dd70
     pc = 0x0000aaaab2e846c0
    Found by: given as instruction pointer in context
 1  code-oss!views::DesktopWindowTreeHostPlatform::OnActivationChanged(bool) [desktop_window_tree_host_platform.cc : 798 + 0x4]
    x19 = 0x00000022002bee00   x20 = 0x0000000000000001
    x21 = 0x0000002200fcfc00   x22 = 0x0000aaaab360b000
    x23 = 0x0000002200f9f7a0   x24 = 0x0000fffffd40e1a0
    x25 = 0x0000002201a24a00   x26 = 0x0000000000000000
    x27 = 0x00000022007f13a0   x28 = 0x0000fffffd40e2b8
     fp = 0x0000fffffd40ddb0    sp = 0x0000fffffd40ddb0
     pc = 0x0000aaaab2e942c8
    Found by: call frame info
 2  code-oss!views::DesktopWindowTreeHostLinux::OnActivationChanged(bool) [desktop_window_tree_host_linux.cc : 305 + 0x8]
    x19 = 0x00000022002bee00   x20 = 0x0000000000000001
    x21 = 0x0000002200fcfc00   x22 = 0x0000aaaab360b000
    x23 = 0x0000002200f9f7a0   x24 = 0x0000fffffd40e1a0
    x25 = 0x0000002201a24a00   x26 = 0x0000000000000000
    x27 = 0x00000022007f13a0   x28 = 0x0000fffffd40e2b8
     fp = 0x0000fffffd40ddd0    sp = 0x0000fffffd40ddd0
     pc = 0x0000aaaab2e9134c
    Found by: call frame info
 3  code-oss!ui::X11Window::AfterActivationStateChanged() [x11_window.cc : 1385 + 0x8]
    x19 = 0x00000022003c2380   x20 = 0x000000220039d140
    x21 = 0x00000022003c24b4   x22 = 0x000001c60000030d
    x23 = 0x00000000000001c6   x24 = 0x0000fffffd40e1a0
    x25 = 0x0000002201a24a00   x26 = 0x0000000000000000
    x27 = 0x00000022007f13a0   x28 = 0x0000fffffd40e2b8
     fp = 0x0000fffffd40de50    sp = 0x0000fffffd40de10
     pc = 0x0000aaaab03e8b0c
    Found by: call frame info
 4  code-oss!ui::X11Window::HandleEvent(x11::Event const&) [x11_window.cc : 0 + 0x8]
    x19 = 0x00000022003c2380   x20 = 0x000000220039d140
    x21 = 0x00000022003c24b4   x22 = 0x000001c60000030d
    x23 = 0x00000000000001c6   x24 = 0x0000fffffd40e1a0
    x25 = 0x0000002201a24a00   x26 = 0x0000000000000000
    x27 = 0x00000022007f13a0   x28 = 0x0000fffffd40e2b8
     fp = 0x0000fffffd40de90    sp = 0x0000fffffd40de70
     pc = 0x0000aaaab03ea9cc
    Found by: call frame info
 5  code-oss!ui::X11Window::DispatchUiEvent(ui::Event*, x11::Event const&) [x11_window.cc : 1266 + 0x8]
    x19 = 0x0000fffffd40e1a0   x20 = 0x0000002200e6b720
    x21 = 0xaaaaaaaaaaaaaaaa   x22 = 0x00000022003c2380
    x23 = 0x00000022015dd0e0   x24 = 0x0000fffffd40e1a0
    x25 = 0x0000002201a24a00   x26 = 0x0000000000000000
    x27 = 0x00000022007f13a0   x28 = 0x0000fffffd40e2b8
     fp = 0x0000fffffd40df20    sp = 0x0000fffffd40ded0
     pc = 0x0000aaaab03eb448
    Found by: call frame info
 6  code-oss!ui::X11Window::DispatchEvent(ui::Event* const&) [x11_window.cc : 1257 + 0x8]
    x19 = 0x00000022003c2380   x20 = 0x0000fffffd40e088
    x21 = 0xaaaaaaaaaaaaaaaa   x22 = 0x0000000000000000
    x23 = 0xaaaaaaaaaaaaaaaa   x24 = 0x0000fffffd40e1a0
    x25 = 0x0000002201a24a00   x26 = 0x0000000000000000
    x27 = 0x00000022007f13a0   x28 = 0x0000fffffd40e2b8
     fp = 0x0000fffffd40dfb0    sp = 0x0000fffffd40df60
     pc = 0x0000aaaab03eb338
    Found by: call frame info
 7  code-oss!non-virtual thunk to ui::X11Window::DispatchEvent(ui::Event* const&) [x11_window.cc : 0 + 0xc]
    x19 = 0x000000220027bf00   x20 = 0x000000220027bf50
    x21 = 0x0000000000000001   x22 = 0x00000022003c23a8
    x23 = 0x0000fffffd40e040   x24 = 0x0000002201a249f0
    x25 = 0x0000002201a24a00   x26 = 0x0000ffffbdf23348
    x27 = 0x00000022007f13a0   x28 = 0x0000fffffd40e2b8
     fp = 0x0000fffffd40e000    sp = 0x0000fffffd40e000
     pc = 0x0000aaaab03eb678
    Found by: call frame info
 8  code-oss!ui::PlatformEventSource::DispatchEvent(ui::Event*) [platform_event_source.cc : 100 + 0x10]
    x19 = 0x000000220027bf00   x20 = 0x000000220027bf50
    x21 = 0x0000000000000001   x22 = 0x00000022003c23a8
    x23 = 0x0000fffffd40e040   x24 = 0x0000002201a249f0
    x25 = 0x0000002201a24a00   x26 = 0x0000ffffbdf23348
    x27 = 0x00000022007f13a0   x28 = 0x0000fffffd40e2b8
     fp = 0x0000fffffd40e070    sp = 0x0000fffffd40e010
     pc = 0x0000aaaab0311304
    Found by: call frame info
 9  code-oss!ui::X11EventSource::OnEvent(x11::Event const&) [x11_event_source.cc : 287 + 0x4]
    x19 = 0x000000220027bf00   x20 = 0x0000fffffd40e1a0
    x21 = 0x000000220039d140   x22 = 0x00000022015d8ec0
    x23 = 0x00000022015d8ef8   x24 = 0x0000000000000000
    x25 = 0x0000ffffbdf22000   x26 = 0x0000ffffbdf23348
    x27 = 0x00000022007f13a0   x28 = 0x0000fffffd40e2b8
     fp = 0x0000fffffd40e0c0    sp = 0x0000fffffd40e0c0
     pc = 0x0000aaaab03968c0
    Found by: call frame info
10  code-oss!x11::Connection::DispatchEvent(x11::Event const&) [connection.cc : 469 + 0x8]
    x19 = 0x0000002200369c00   x20 = 0x0000fffffd40e1a0
    x21 = 0x0000fffffd40e120   x22 = 0x00000022015d8ec0
    x23 = 0x00000022015d8ef8   x24 = 0x0000000000000000
    x25 = 0x0000ffffbdf22000   x26 = 0x0000ffffbdf23348
    x27 = 0x00000022007f13a0   x28 = 0x0000fffffd40e2b8
     fp = 0x0000fffffd40e150    sp = 0x0000fffffd40e0f0
     pc = 0x0000aaaaad7f98c4
    Found by: call frame info
11  code-oss!x11::Connection::Dispatch() [connection.cc : 0 + 0x1c]
    x19 = 0x0000002200369c00   x20 = 0x0000002200369de0
    x21 = 0x0000002200369e58   x22 = 0x0000002200279080
    x23 = 0x0000aaaab0399e18   x24 = 0x0000000000000000
    x25 = 0x0000ffffbdf22000   x26 = 0x0000ffffbdf23348
    x27 = 0x00000022007f13a0   x28 = 0x0000fffffd40e2b8
     fp = 0x0000fffffd40e1d0    sp = 0x0000fffffd40e190
     pc = 0x0000aaaaad7f9548
    Found by: call frame info
12  code-oss!ui::(anonymous namespace)::XSourceDispatch(_GSource*, int (*)(void*), void*) [x11_event_watcher_glib.cc : 55 + 0x4]
    x19 = 0x0000002200369c00   x20 = 0x0000000000000000
    x21 = 0x0000002200b2e8f0   x22 = 0x0000002200279080
    x23 = 0x0000aaaab0399e18   x24 = 0x0000000000000000
    x25 = 0x0000ffffbdf22000   x26 = 0x0000ffffbdf23348
    x27 = 0x00000022007f13a0   x28 = 0x0000fffffd40e2b8
     fp = 0x0000fffffd40e220    sp = 0x0000fffffd40e220
     pc = 0x0000aaaab0399e30
    Found by: call frame info
13  libglib-2.0.so.0 + 0x51800
    x19 = 0x000000220028dae0   x20 = 0x0000000000000000
    x21 = 0x0000002200b2e8f0   x22 = 0x0000002200279080
    x23 = 0x0000aaaab0399e18   x24 = 0x0000000000000000
    x25 = 0x0000ffffbdf22000   x26 = 0x0000ffffbdf23348
    x27 = 0x00000022007f13a0   x28 = 0x0000fffffd40e2b8
     fp = 0x0000fffffd40e240    sp = 0x0000fffffd40e240
     pc = 0x0000ffffbde3c804
    Found by: call frame info

[deepak1556]

I haven't debugged this on my machine yet, but it very likely might be the focus call before the window is completely setup https://github.com/microsoft/vscode/blob/main/src/vs/platform/windows/electron-main/window.ts#L671

There have also been some recent changes in the activation event code path https://chromium-review.googlesource.com/c/chromium/src/+/3474337, will see if that helps as well.

[bpasero]

@deepak1556 however, the crash also happens when selecting "Close" and in that way we do not open a new window. Even removing the window.focus() call does not seem to help when I pick "Reopen".

[bpasero]

Btw this seems to reproduce with Electron 13 even, just tried from an older version of VSCode.