Diff Editors are not closed when running `Git: Close All Diff Editors`

[noalbalint]

Does this issue occur when all extensions are disabled?: YES

• VS Code Version:
  Version: 1.67.2
  Commit: c3511e6
  Date: 2022-05-17T18:20:57.384Z
  Electron: 17.4.1
  Chromium: 98.0.4758.141
  Node.js: 16.13.0
  V8: 9.8.177.13-electron.0
  OS: Darwin x64 21.4.0

• OS Version: macOS 12.3.1

Steps to Reproduce:

1. open command pallete
2. select Git: Close All Diff Editors

does not close the diff editors:

Screen.Recording.2022-05-24.at.2.08.38.PM.mov

wasn't able to reopen #143746 because I'm not a contributor, but its the same bug.

[lszomoru]

@noalbalint, are you able to reproduce this issue all the time? I have been trying to reproduce it without any luck? Would you be able to include the "Source Control" view in the recording to see the current state of that view as well? Also, are you able to reproduce the issue if you start VS Code using code --disable-extensions? Thanks!

[lszomoru]

I believe I have a repro for this issue:

• Set git.closeDiffOnOperation to false
• Open a folder/workspace with a git repository
• Make changes to one or more files
• Switch to the "Source Control" viewlet and double click on each modified file which will open the diff editor
• Commit the changes. Since git.closeDiffOnOperation is set to false the diff editors will not be closed
• Invoke the Git: Close All Diff Editors command

Expected behaviour

• Diff editors should be closed

Actual behaviour

• Diff editors are not closed