Config changes for relaunch even when user cancels

[rzhao271]

1. Navigate to the Settings editor
2. Toggle the workbench.experimental.settingsProfiles.enabled setting
3. A dialog should pop up. Press Cancel
4. The setting is still saved in the JSON

A more difficult case is when the user changes the value in the Settings JSON file and is prompted for a reload, but then the user cancels the reload. In that case, do we know what to revert back to in case the user presses cancel? @sandy081

[bpasero]

But the user cancels the reload, not changing settings, so what is the bug here?

[sandy081]

This is true for all those settings which require reload.

[rzhao271]

But the user cancels the reload, not changing settings, so what is the bug here?

I confirmed that after the user clicks the checkbox in the Settings UI, the setting is written to the backend. Therefore, if the user cancels the reload, the setting has been changed but the window hasn't been reloaded, which might cause glitches.

[vscodenpa]

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!