To verify:

Using the webview sample
Apply the following diff to enable just one command (open settings). The compile error is expected until you update to latest VS Code typings:

diff --git a/webview-sample/src/extension.ts b/webview-sample/src/extension.ts
index d2b6e26..444a67c 100644
--- a/webview-sample/src/extension.ts
+++ b/webview-sample/src/extension.ts
@@ -39,6 +39,8 @@ function getWebviewOptions(extensionUri: vscode.Uri): vscode.WebviewOptions {
 		// Enable javascript in the webview
 		enableScripts: true,
 
+		enableCommandUris: ['workbench.action.openGlobalSettings'],
+
 		// And restrict the webview to only loading content from our extension's `media` directory.
 		localResourceRoots: [vscode.Uri.joinPath(extensionUri, 'media')]
 	};
@@ -203,10 +205,8 @@ class CatCodingPanel {
 				<title>Cat Coding</title>
 			</head>
 			<body>
-				<img src="${catGifPath}" width="300" />
-				<h1 id="lines-of-code-counter">0</h1>
-
-				<script nonce="${nonce}" src="${scriptUri}"></script>
+			<a href="command:workbench.action.openGlobalSettings">Open settings (should work)</a>
+			<a href="command:workbench.action.openGlobalKeybindings">Open keybindings (should not work)</a>
 			</body>
 			</html>`;
 	}

Run sample and try triggering the command links. The one for open settings should work while any other command links should not work

Let webviews specify an allowlist of commands that can be run with commands uris #163500

Description

Feature request

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions