[json] hovers for `const` should look the same as with `enum`

[MariaSolOs]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.74.0-insider
• OS Version: Windows_NT x64 10.0.22623

In a package.json file, JSON hovers will correctly use the description of the property or the value for enum types. For example, notice the difference when hovering over extensionKind versus hovering over workspace:

This isn't always the case in other files, even when a JSON schema that has descriptions for the property and each value is included. As an example, dprint is an extension that has JSON schemas for each of its plugins (example), but then hovers only use the description of the current value:

From just a quick look it seems like dprints schema is correct, so this might be a problem with the JSON language service...?

[aeschli]

The first on euses enum, the second oneOf and const.

{
	type: 'string',
	description: 'Define the kind of an extension.',
	enum: [
		'ui',
		'workspace'
	],
	enumDescriptions: [
		'UI extension kind. In a remote window, such extensions are enabled only when available on the local machine.',
		'Workspace extension kind. In a remote window, such extensions are enabled only when available on the remote.'
	],
};

    "quoteStyle": {
      "description": "How to use single or double quotes.",
      "type": "string",
      "default": "alwaysDouble",
      "oneOf": [{
        "const": "alwaysDouble",
        "description": "Always uses double quotes."
      }, {
        "const": "alwaysSingle",
        "description": "Always uses single quotes."
      }, {
        "const": "preferDouble",
        "description": "Prefers using double quotes except in scenarios where the string contains more double quotes than single quotes."
      }, {
        "const": "preferSingle",
        "description": "Prefers using single quotes except in scenarios where the string contains more single quotes than double quotes."
      }]
    },

The first one shows description which is standardized and 'enumDescriptions', which is a VS Code custom property, and only used by our own settings schemas.
For the second one, only with additional tests we know that the const is a enum value. We currently only show the description of the const. But the schema author is free to put any description there.

So this is not a bug, but caused by the different ways of how the enumeration is expressed.

[vscodenpa]

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[MariaSolOs]

Thanks @aeschli for explaining! I think that at least it would be helpful to offer JSON schema extenders a way to provide the same experience as the one in internal JSON APIs :)

[vscodenpa]

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[vscodenpa]

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!