Complete step once step is viewed #166987
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lramos15
approved these changes
Nov 22, 2022
Member
lramos15
left a comment
lramos15
left a comment
There was a problem hiding this comment.
Just find all references on the completion events before removing them to make sure they're no longer used.
Contributor
|
If we're doing this, should we also make the checkbox non-interactive? Not sure if there's still value in letting people manually toggle it.
Let's see how it feels first. I suspect we should add it but we can give it a try first. |
daviddossett
approved these changes
Dec 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #166747.
The checkbox now is toggled on select. The completion events now seem to be unnecessary?
Should we consider adding Next button as a part of this task itself or would we consider that after user feedback? cc: @daviddossett