Skip to content

Conversation

@connor4312
Copy link
Member

@connor4312 connor4312 commented Nov 23, 2022

Fixes #130548. Adds an efficient test-by-uri lookup that are used by decorations and also to set a new context key.

@connor4312 connor4312 enabled auto-merge (squash) November 23, 2022 19:34
@connor4312 connor4312 self-assigned this Nov 23, 2022
@connor4312 connor4312 marked this pull request as draft November 23, 2022 19:35
auto-merge was automatically disabled November 23, 2022 19:35

Pull request was converted to draft

@connor4312 connor4312 marked this pull request as ready for review November 23, 2022 20:04
@vscodenpa vscodenpa added this to the November 2022 milestone Nov 23, 2022
"search.exclude": {
"**/node_modules": true,
"**/bower_components": true,
"cli/target/**": true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small unrelated fix: I noticed search was getting slow, which I assumed was Defender, but it was actually looking through all the build output in the CLI

if (internalTest.expand === TestItemExpandState.BusyExpanding) {
this.busyControllerCount++;
}
case TestDiffOpType.Add:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic in these cases were moved down verbatim. I was originally considering overriding them and didn't, but I think this is still some decent cleanup

@connor4312 connor4312 enabled auto-merge (squash) November 23, 2022 20:08
@connor4312 connor4312 merged commit 387bab6 into main Nov 23, 2022
@connor4312 connor4312 deleted the connor4312/test-in-submenus branch November 23, 2022 20:32
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose Run and Debug test to other UI entries?

4 participants