PHP formatting on typing

[ygoe]

Type: Bug

When I type HTML code in a PHP file, the closing tags are always moved to the first column, deleting and indentation tabs in front of them. Even if it's wrong and this wouldn't happen in an HTML document. I have no PHP-related extensions installed. Disabling the editor.formatOnType feature for PHP files does not resolve the issue. I assume the core editor has a broken behaviour that needs to be fixed or removed.

Steps to reproduce:

1. Open a .php file
2. In an HTML section (not in PHP code) within an element, indented by tabs, type this: <ul> (newline) </ul>

Expected result (example):

    <div>
        <ul>
        </ul>
    </div>

Actual result (example):

    <div>
        <ul>
</ul>
    </div>

VS Code version: Code 1.74.2 (e8a3071, 2022-12-20T10:29:14.590Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Sandboxed: No

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-3770 CPU @ 3.40GHz (8 x 3400)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: disabled_off
Load (avg)	undefined
Memory (System)	15.71GB (5.85GB free)
Process Argv	--crash-reporter-id 1b00a758-578c-4b77-a258-fe145c18e004
Screen Reader	no
VM	31%

Extensions (24)

Extension	Author (truncated)	Version
vscode-solution-explorer	fer	0.7.5
vscode-todo-highlight	jgc	2.0.4
ecdc	mit	1.8.0
vscode-language-pack-de	MS-	1.74.12140926
csharp	ms-	1.25.2
vscode-dotnet-runtime	ms-	1.6.0
isort	ms-	2022.8.0
python	ms-	2022.20.1
vscode-pylance	ms-	2023.1.10
jupyter	ms-	2022.11.1003412109
jupyter-keymap	ms-	1.0.0
jupyter-renderers	ms-	1.0.12
vscode-jupyter-cell-tags	ms-	0.1.6
vscode-jupyter-slideshow	ms-	0.1.5
remote-ssh	ms-	0.94.0
remote-ssh-edit	ms-	0.84.0
cpptools	ms-	1.13.9
remote-explorer	ms-	0.0.3
vscode-nuget-gallery	pat	0.0.24
platformio-ide	pla	2.5.5
better-pageup-pagedown	rus	0.0.1
jinjahtml	sam	0.19.0
trailing-spaces	sha	0.4.1
cursorCharCode	zei	0.2.2

(1 theme extensions excluded)

A/B Experiments

vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscorecescf:30445987
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
azure-dev_surveyone:30548225
pyindex848:30577860
nodejswelcome1cf:30587006
2e4cg342:30602488
3d0df643:30613357
89544117:30613380
fim-prod:30623723

[roblourens]

As a workaround, you can set editor.autoIndent to anything less than "Full"

[roblourens]

Here the .php file is inheriting html's indentationRules, and the decreaseIndentPattern is apparently being applied twice. @alexdima I was debugging a bit, and I think this could be an issue with how decreaseIndentPattern is applied for inherited rules?

[roblourens]

Here, we look up indentRulesSupport for the language from the ScopedLineTokens

vscode/src/vs/editor/common/languages/autoIndent.ts

Line 411 in 70c45ba

const indentRulesSupport = languageConfigurationService.getLanguageConfiguration(scopedLineTokens.languageId).indentRulesSupport;

, that is html which is correct.

But here when we figure out the inherited indentation from the previous line, we look it up using the model's language

vscode/src/vs/editor/common/languages/autoIndent.ts

Line 84 in 70c45ba

const indentRulesSupport = languageConfigurationService.getLanguageConfiguration(model.tokenization.getLanguageId()).indentRulesSupport;

which is php, which is not correct. So then it thinks that this line was not indented so the current line gets deindented beyond the previous line.

Not sure what the fix is, maybe computing a ScopedLineTokens for the previous line as well

[ygoe]

So it looks like advanced is the next smaller level. Setting the option to that removes all automatic indentation from HTML in PHP files. Now I'm back (down and also up) to the level that Notepad++ provides.

I also had to set this for HTML files because it also has undesired side effects. Pasting a multi-line element that needs to go on another indentation level would have indented it correctly, but mis-indented the closing tag below the pasted lines. I never meant to edit that line, yet it was touched to the worse.

Is it possible at all that VSCode could properly indent HTML (in HTML or PHP files)? Do I have to install any extensions to make it work or would it be supposed to work out of the box?