Delayed pty host startup can cause terminal service connection state to stay connecting

[Tyriar]

Repro:

1. Set "terminal.integrated.developer.ptyHost.startupDelay": 10000
2. Reload window
3. Create a terminal before pty host is connected
4. When pty host is connected, pretty ctrl+`, 🐛 the terminal is opened but not focused.

Relevant code:

vscode/src/vs/workbench/contrib/terminal/browser/terminalService.ts

Lines 266 to 278 in 8adc6e0

	// Connect to the extension host if it's there, set the connection state to connected when
	// it's done. This should happen even when there is no extension host.
	this._connectionState = TerminalConnectionState.Connecting;
	const isPersistentRemote = !!this._environmentService.remoteAuthority && enableTerminalReconnection;
	if (isPersistentRemote) {
	this._reconnectToRemoteTerminals().then(() => this._setConnected());
	} else if (enableTerminalReconnection) {
	this._reconnectToLocalTerminals().then(() => this._setConnected());
	} else {
	Promise.resolve().then(() => this._setConnected());
	}

[bison92]

Hi,
I wanted to report an issue with the terminal that started happening from yesterday.

I start the terminal right after opening vscode, and the first time I do this vscode will get quite unresponsive and complaint about a timeout contacting the pty host. This is happening in both windows and debian OS in different PCs.

I see you opened a bunch of issues related to the terminal in the last 24h, I'm not sure which relates more to what I'm experiencing but I hope this helps. @Tyriar

[Tyriar]

@bison92 sorry about that, here's the issue you're hitting and summary of the fixes: #130320 (comment)