`workspace.applyEdit` might not await the edit

[senyai]

It's late evening, but still I think this is vscode issue and not mine.

• VS Code Version: 1.80
• OS Version: PopOS based on Ubuntu 22.04

Steps to Reproduce:

1. Sorry, it's not easy to reproduce. Run a code like this:

    const edit = new WorkspaceEdit();
    edit.replace(
        modifiedUri,
        new Range(
            new Position(0, 0),
            modifiedDocument.lineAt(modifiedDocument.lineCount - 1).range.end
        ),
        result
    );
    await workspace.applyEdit(edit);
    await modifiedDocument.save();
   

2. immediately after all this, call document.getText() and get the text in the process of modification.

It doesn't happen in 100% cases, but adding console.log('text') in between makes the text fine all the time. I think it worked in 1.79.2

[vscodenpa]

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.80.0. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

[senyai]

workspace.applyEdit:
@return A thenable that resolves when the edit could be applied
what does it mean exactly and should the user of this API check returned value?

[jrieken]

should the user of this API check returned value

Yes - if false is being returned than all bets are off. It means the document has been changed in the meantime or something else preventing applying the edits. Check the window and extension host logs for more details

Please check for the applyEdit result and please make you sample complete

[senyai]

I believe I see 4 different issues pop up that have the same root cause.

Now to the steps. Checkout my extension https://github.com/senyai/vscode-fossil/tree/vscode-issue-187396. install fossil (it's in all package managers I know of). open vscode, npm install and run 'Launch Tets' in debug panel. The tests will fail randomly.

[vscodenpa]

Hey @jrieken, this issue might need further attention.

@senyai, you can help us out by closing this issue if the problem no longer exists, or adding more information.

[senyai]

I followed the steps above and still saw this issue in the latest vscode release 1.82.2. If nobody is experiencing this issue it must be something on my side, so let me close it.
@jrieken thanks for your help.