Support transferring input placeholder across workspaces #188415
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyceerhl
reviewed
Jul 20, 2023
bhavyaus
force-pushed
the
dev/bhavyau/interactive
branch
from
51c2644 to
1358b5e
Compare
joyceerhl
reviewed
Jul 20, 2023
bhavyaus
force-pushed
the
dev/bhavyau/interactive
branch
from
1358b5e to
e801256
Compare
joyceerhl
suggested changes
Jul 21, 2023
Contributor
joyceerhl
left a comment
joyceerhl
left a comment
There was a problem hiding this comment.
Discussed offline, IMHO there's no current need to support customizing the input value in the transfer state, we should add that later if we end up needing it
| requester: InteractiveSessionParticipantInformation; | ||
| responder: InteractiveSessionParticipantInformation; | ||
| inputPlaceholder?: string; | ||
| inputValue?: string; |
Contributor
There was a problem hiding this comment.
Is this property in use somewhere? We should be careful not to break existing extension consumers
Collaborator
Author
Changed to saving the input in the chat model itself: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
In the /createWorkspace scenario, creating and opening a new workspace does not pre-populate the slash command since the input view state is not transferred across workspaces.