Walkthroughs: Permit completion events #191443
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CC @daviddossett who made the original issue (sorry if I'm just making noise). My motivation for this proposal is to use walkthroughs as a way to get users started with our fairly complex extension. They might need some external software and they might have to do some configuration, and the walkthrough mechanism would be the perfect vessel for this type of onboarding if it actually did what it said in the documentation. |
trond-snekvik
force-pushed
the
walkthrough_completion_events
branch
from
8668069 to
ffd2638
Compare
trond-snekvik
force-pushed
the
walkthrough_completion_events
branch
from
ffd2638 to
146190c
Compare
This is a counter proposal to the solution in microsoft#172941, which quietly breaks the completion event mechanism in extension walkthroughs. This reverts microsoft#172941 in favor of a fallback in the walkthrough service, which now responds to `stepSelected` if no completion event is explicitly defined. This maintains the current functionality for walkthroughs that aren't explicitly defining their own completion events. Fixes microsoft#176074. Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
trond-snekvik
force-pushed
the
walkthrough_completion_events
branch
from
146190c to
7af77c2
Compare
Collaborator
|
We've fixed this issue and it should be available in the insiders build. Closing this pr. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a counter proposal to the solution in #172941, which quietly breaks the completion event mechanism in extension walkthroughs.
This reverts #172941 in favor of a fallback in the walkthrough service, which now responds to
stepSelectedif no completion event is explicitly defined. This maintains the current functionality for walkthroughs that aren't explicitly defining their own completion events.Fixes #176074.