align accept keybindings

[meganrogge]

• Ctrl+Enter is used in the inline chat widget to accept a suggestion
• Ctrl+/ is used in the accessible view to accept an inline completion suggestion
• There is no keybinding to insert the current chat code block suggestion at the current cursor location
• Ctrl+Enter is used to submit a comment from within a comment widget

@jooyoungseo suggested aligning these.

@roblourens what do you think of adding a default keybinding of Ctrl+Enter for inserting the current chat code block at the current cursor location?

I will change the inline completion suggestion acceptance in the accessible view to Ctrl+Enter.

[jooyoungseo]

@meganrogge --

what do you think of adding a default keybinding of Ctrl+Enter for inserting the current chat code block at the current cursor location?

Did you mean ctrl+/?

Ctrl+Enter is used to submit a comment from within a comment widget

I think ctrl+enter can be used for submission. There is no issue with this key. Submitting pull request, for example, is also ctrl+enter. However, when Accepting something, we may want to use ctrl+/ for the consistency.

[meganrogge]

@jooyoungseo I was suggesting we align all of these to use ctrl+enter rather than ctrl+/.

[meganrogge]

I don't think people will be in favor of Ctrl+/ to accept in the inline chat widget as that would break muscle memory.

[jooyoungseo]

@meganrogge -- FYI, the following keybinding is also ctrl+/:

github.copilot.acceptCursorPanelSolution

[meganrogge]

I've refined the original content of this issue to reflect the ask. We shall see what people say.

[jooyoungseo]

Here is my summary:

1. Use ctrl+enter for submitting actions. Evidence: GitHub Pull Request uses this keybinding. Also, "Report Issue" under Help menu also adopts ctrl+enter as its default keybinding for submitting issue content.

2. Use ctrl+/ for accepting or inserting suggestions. Evidence: github.copilot.acceptCursorPanelSolution already uses this keybinding. Also, Accessible View adapted this for accepting the current inline suggestion.

[jrieken]

@jrieken what do you think of using Ctrl+/ for the inline chat widget to accept a suggestion (at least when in screen reader mode)?

I think that's not a good keybinding and that Ctrl+Enter is way better because it's easier to reach, e.g on a DE/CH keyboard you need to press Shift+7 to get /

[jooyoungseo]

I am then not against unifying all the listed keybindings in favor of `ctrl+Enter`.