"View: Show GitHub" keyboard shortcut focuses wrong activity view

[tomwyr]

Extension version: 0.76.1
VSCode Version: 1.84.2
OS: Windows 11
Steps to Reproduce:

Open the "Keyboard Shortcuts" menu from the command palette
Set some non-existing keybinding (e.g. Shift+Ctrl+K) for "View: Show GitHub"
Press the shortcut set in step 2.
Expected behavior: The Github activity view is focused.
Actual behavior: The Explorer view is focused.

[tomwyr]

Also the shortcut isn't assigned when right-clicking on the activity tab:

[tomwyr]

@alexr00 Following your comment from microsoft/vscode-pull-request-github#3451. The Issues and Pull Requests screens contain information about repo/project not related to any specific PR and it'd make sense to allow for accessing those tabs also when not in review mode.

[alexr00]

@tomwyr as you say, the "GitHub" view container is not about the active PR so this command should work. I think you're having view state problems, and in fact I can repro your issue if I do the following:

1. Check out a PR.
2. Drag the "Issues" view to a new view container.
3. Drag the "Pull Requests" view in the same view container. Repeat with the 2 views in the "GitHub Pull Request" view container
4. Try to run "View: Show GitHub"

[alexr00]

@sbatten and @sandy081, If you follow the stepsin #198540 (comment), you end up with a view container that still appears to be named "GitHub":

But, the original "View: Show GitHub" command is not longer available in the command palette, so this is very confusing. How can a user run a command to show a view container that was created by dragging a view into a new container?

[sandy081]

It creates a new view container and also creates a command View: Focus GitHub. Can you please check?

[alexr00]

I don't see that command:

[sandy081]

Can you please check the custom containers list those are shown on the bottom (with UUID). There should be a command for each view container

[alexr00]

I see actions for the two views in the container, but not for the container

[sandy081]

Have you moved Issues and Pull Requests views into two separate containers?

[alexr00]

No, they're in the same one:

[sandy081]

Got it. It seems View: Show... commands are created for registered view containers and View: Focus... commands are created for registered views. There are no commands created for custom view containers. @sbatten might know why.

User can associate keyboard shortcuts to View Focus... commands so that these keyboard shortcuts will work where-ever these views are moved. If you register a keyboard shortcut to View container commands they will not move with views.