Sorting line does not properly sort quoted strings

[sroucheray]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.84.2
• OS Version: Linux x64 5.14.0-1054-oem

Steps to Reproduce:

1. Open an SCSS file with the following content:

@import 'file-a-aaa';
@import 'file-a';
@import 'file-a-ccc';
@import 'file-a-bbb';

2. select all lines
3. CTRL+P then trigger "Sort line ascending"

Result:

@import 'file-a-aaa';
@import 'file-a-bbb';
@import 'file-a-ccc';
@import 'file-a';

NB: last line is position here because in the sort algorithm of Int.Collator the character - (e.g. line 3: @import 'file-a- <-- this one) comes before the character '.

Expected result:

@import 'file-a';
@import 'file-a-aaa';
@import 'file-a-bbb';
@import 'file-a-ccc';

NB: it feels more "natural" to me to have @import 'file-a'; on the first line when sorting. For this we might ignore punctuation when sorting by explicitly setting it here

SortLinesCommand._COLLATOR = new Intl.Collator(undefined, { ignorePunctuation: true });

I see two ways to fix the problem:

1. Hard ignoring punctuation considering it is a better default
2. Introduce a new setting for line sorting: ignorePunctuation : true | false (default) to keep current behavior but make it possible to change it

[phudson]

"Hard ignoring punctuation considering it is a better default"

Not for my use-cases. So option 2, or just leave it to an extension for people who want more flexibility?

[sroucheray]

Not for my use-cases. So option 2, or just leave it to an extension for people who want more flexibility?

I suspect there is no entry point for extension authors to change the default behavior of the "sort action" (but I may be wrong, someone could tell ?).

So a third option would be to introduce an entry point for extension authors.

[sroucheray]

@aeschli if this feature is of interest, for any chosen option, I am willing to provide a PR.

[hediet]

/duplicate (there is some issue discussing sorting)

[sroucheray]

For the ref #60978

[hediet]

Thanks for looking up the duplicate! I'm currently responsible for more than 500 open issues and get many notifications every day, I have to prioritize my work to actually getting things done, so please understand why I couldn't take the time myself.

[sroucheray]

My mistake, I am so sorry. I usually search for existing issues before creating new ones, whatever the repo. Obviously this was not the case for this one.
BTW. Keep up the good work, and thanks for taking the time to answer.