CTRL+SHIFT+F no longer searching when pressed

[mdealer]

Type: Bug

It is not searching when pressed and keeps showing old results. I need to manually change filter options for it to search.

Is this some kind of a stealth user study? I observed how this changed from always working, to sometimes not working, to mostly not working to almost never working. This function needs a stress test or something, there is no obvious thing broken other than the search not searching by default.

VS Code version: Code 1.85.0 (af28b32, 2023-12-06T20:48:09.019Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item	Value
CPUs	AMD Ryzen 9 5900HX with Radeon Graphics (16 x 3294)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: enabled_on direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled
Load (avg)	undefined
Memory (System)	31.36GB (16.09GB free)
Process Argv	--folder-uri file:///c%3A/w/jenkins/integration-jenkins-branch --crash-reporter-id 5495b1a5-cac6-4d84-bf9e-715b45538350
Screen Reader	no
VM	0%

Extensions (14)

Extension	Author (truncated)	Version
jelly-language-support	Act	1.2.2
codeium-enterprise	Cod	1.4.25
codeium-enterprise-updater	Cod	1.0.12
code-runner	for	0.12.1
test-adapter-converter	ms-	0.1.8
vscode-jest	Ort	5.2.3
java	red	1.25.1
intellicode-api-usage-examples	Vis	0.2.8
vscodeintellicode	Vis	1.2.30
vscode-java-debug	vsc	0.55.0
vscode-java-dependency	vsc	0.23.3
vscode-java-pack	vsc	0.25.15
vscode-java-test	vsc	0.40.1
vscode-maven	vsc	0.43.0

A/B Experiments

vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
py29gd2263:30899288
vsclangdc:30486549
c4g48928:30535728
dsvsc012cf:30540253
azure-dev_surveyone:30548225
2e4cg342:30602488
f6dab269:30613381
2i9eh265:30646982
showlangstatbar:30737416
962ge761:30917236
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
welcomedialogc:30910334
pythonnosmt12:30797651
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
dsvsc013:30795093
dsvsc014:30804076
dsvsc015:30845448
pythontestfixt:30902429
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
h48ei257:30885898
pythontbext0:30879054
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
aa_t_chat:30882232
dsvsc019:30917259

[gjsjohnmurray]

One situation where Ctrl+Shift+F from a selected word in an editor primes the search field in the Search view but doesn't search for that word until you press Enter is if you dismissed (with its X button) any of the results from your previous search.

This is by design.

[mdealer]

Good to know. I remember using the dismissal of search results more and more, which explains why it got worse over time. Though, I don't find this useful in its current form. Probably makes sense to have a dedicated button for pinning the results, because almost always I click away the irrelevant results just to go over the results with my eyes. Only after many hectic search operations and eyeballing I actually use it as a TODO list. Kind of optimized backwards for my use case.

[mdealer]

Sorry for double post, but just now I encountered a case repeatedly where it does not search even if I did not dismiss any results, so there is something going on and it is getting worse after all?

[andreamah]

Good to know. I remember using the dismissal of search results more and more, which explains why it got worse over time. Though, I don't find this useful in its current form. Probably makes sense to have a dedicated button for pinning the results, because almost always I click away the irrelevant results just to go over the results with my eyes. Only after many hectic search operations and eyeballing I actually use it as a TODO list. Kind of optimized backwards for my use case.

I think that the reason that we do this is because people could easily lose their state with their current dismissed results, so making people do CTRL+SHIFT+F then ENTER is a way to ensure that they actually want to overwrite their results. If we were to have a "pinned" button, it would be slightly confusing in how it should act in conjunction with the "clear all results" button. It would be more of a "does CTRL+SHIFT+F actually force a re-search" button, which would be a bit too specific for a button. I could maybe consider a setting for enforcing this if it is popular enough.

Sorry for double post, but just now I encountered a case repeatedly where it does not search even if I did not dismiss any results, so there is something going on and it is getting worse after all?

I can't seem to reproduce this. Can you post a screen recording?

[vscodenpa]

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

[mdealer]

I think that the reason that we do this is because people could easily lose their state with their current dismissed results, so making people do CTRL+SHIFT+F then ENTER is a way to ensure that they actually want to overwrite their results. If we were to have a "pinned" button, it would be slightly confusing in how it should act in conjunction with the "clear all results" button. It would be more of a "does CTRL+SHIFT+F actually force a re-search" button, which would be a bit too specific for a button. I could maybe consider a setting for enforcing this if it is popular enough.

To me it feels like a crutch. I haven't seen any editors do this before, so it's confusing to get a crutch shipped with the bicycle in the same package so to speak. It looks like a non-dialog, but somehow it works as a dialog, but not always. To me it feels out of sync. Maybe it is just me, but it breaks the flow.

I can't seem to reproduce this. Can you post a screen recording?

Sorry, can't. It seems it happens when I start writing on the affected lines and they disappear off the list by themselves.