Unnecessary calls to 'codeAction/resolve' on mouse hovers

[dbalek]

Type: Bug

Hovering with mouse over a list of available code actions that appears after clicking on a lightbulb displayed in the editor left margin (the same applies for the list of code actions that appears after right click in editor and selecting Source Action...), codeAction/resolve LSP call is invoked for each affected code action. This is not done when cycling the list using keyboard Up/Down when the codeAction/resolve is called only on the code action selected by user as to be performed.
The unnecessary calls to codeAction/resolve (caused by simple mouse hovers) represent a performance problem since the codeAction/resolve call is usually used to compute the edit property of a code action which could by quite costly (that was the reason to introduce the codeAction/resolve to LSP in version 3.16)

VS Code version: Code 1.85.1 (0ee08df, 2023-12-13T09:47:11.635Z)
OS version: Linux x64 6.6.3-1-default
Modes:

[justschen]

@dbalek yes this was intentional (ref #175008) since we wanted to compute if there were edits in order to show a hover, which is why we resolve on hover (code action isn't applied, but just resolved in the background).

I do see that this causes a 300ms long task to run on hover which isn't ideal, as you mentioned resolve is costly.

giving this another look, thanks for bringing it up 👍

[stoichitescumaria]

I've got a similar problem as well. I am using the codeAction/resolve call to collect user input for the proposals that require it. With the new implementation, the user input will be requested whenever a proposal is hovered over, making it unselectable when using the mouse. Could you provide any additional information on the codeAction/resolve call as to whether it was triggered by selecting a proposal or by hovering over it?