Skip to content

Improve app.quit() calls #22138

@joaomoreno

Description

@joaomoreno

Due to moving the shared process to a window.

Currently, electron-main/main.ts detects that when there are no more workbench windows open, and not on macOS, it disposes the shared process, which closes its window, which fires the all-windows-closed event, which triggers app.quit().

The windows service should be the one responsible for this:

  • It should detect that no more workbench windows are open, not on macOS, and call ILifecycleService.quit()
  • the LifecycleService should be the single point of app.quit() calls

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions