Can't get a code instance to attach to debug server

[QwertyZW]

• VSCode Version: 1.10.2
• OS Version: Tried on both ubuntu 16.04 and Windows 10 (up to date)

Steps to Reproduce:

I'm simply trying to debug a debug adapter following the instructions under the contributing section of this extension https://github.com/QwertyZW/vscode-php-debug

I get to the point where I start the vscode debugger in server mode waiting for a connection from the client vs code instance

node --debug-brk=12752 --nolazy out\phpDebug.js --server=4711 
Debugger listening on [::]:12752
waiting for debug protocol on port 4711

Spawning off a new vscode instance

code testproject --extensionDevelopmentPath=.

From the embedded terminal, and then trying various approaches to get a connection established have all gone in vain. I tried both ubuntu 16.04 and windows 10 with no luck.

https://code.visualstudio.com/images/example-debuggers_debug-extension-server.png

I can't get to the point where it says > accepted connection from client

[weinand]

@QwertyZW if your debug adapter is running in server mode, make sure that your launch config has an "debugServer": 4711 attribute. This will make VS Code connect to the server instead of starting the debug adapter in non-server mode.
And you don't have to relaunch VS Code for this.

/cc @felixfbecker

[QwertyZW]

Right, I've already made sure I had that covered as per @felixfbecker 's instructions. Not sure what I'm doing wrong here.

I'm not sure what version of node vscode is resorting to when doing

node --debug-brk=6725 --nolazy out/phpDebug.js --server=4711 
Debugger listening on [::]:6725
waiting for debug protocol on port 4711

So I made sure the version of the node in my path matched vscode's. That didn't make any difference though.

[QwertyZW]

Oddly enough; this is what ended up working out for me. I don't understand why though.

QwertyZW/vscode-php-debug@85d2a60

[QwertyZW]

It seems to require an attribute per config in order to debug said config, while ignoring parent attribute.

QwertyZW/vscode-php-debug@85d8edb

[felixfbecker]

This used to be a top-level attribute, seems like it was changed to per-config?

[weinand]

@QwertyZW yes, the "debugServer" attribute was moved from the top-level of the launch.json to an individual configuration in November: https://code.visualstudio.com/updates/v1_8#_debugger-extension-authoring.

[weinand]

@isidorn when using the "debugServer" attribute on the top level, I do not get a warning. Do you know why?

[isidorn]

@weinand because I removed the warning, it was there only for 2 milestones

[weinand]

@isidorn sure, but I'm not asking for a deprecation warning any more. Now the attribute is unexpected and should result in the generic JSON schema warning for unexpected attributes.

[isidorn]

We never showed warnings for unexpected attributes. Sounds like a feature request for the json schema

[felixfbecker]

@isidorn that doesn't seem to be the case, at least not in a config section.