SCM Graph - branch pills height regressed in the history item hover

[lszomoru]

The heigh of the pill Insiders is different vs what is in Stable. Possible regression to the hover CSS changes.

[Tyriar]

This might have changed with #228136? Do you just want more bottom and top padding? How do you give them the round borders right now?

[lszomoru]

Yes, I would like to have the previous top/bottom padding restored.
Round borders are done using the style attribute as the hover is being created in core.

[Tyriar]

@lszomoru can you point to the code? The solution is likely to adjust padding of the spans in a similar way to border-radius.

[lszomoru]

vscode/src/vs/workbench/contrib/scm/browser/scmHistoryViewPane.ts

Lines 531 to 532 in 9d2ecac

	return `<span style="color:${labelForegroundColor};background-color:${labelBackgroundColor};border-radius:10px;">&nbsp;$(${labelIconId})&nbsp;${ref.name}&nbsp;&nbsp;</span>`;
	}).join('&nbsp;&nbsp;'));

[Tyriar]

Yes I think you need to do it there. The reason being we never intentionally set out to support this pill format, it was just a coincidence it used to look like what you wanted. And we want the styling to be as slim as possible generally.