Login state flaky across windows when triggered by multiple extensions

[deepak1556]

Testing #238868

1. Start with a fresh profile
2. Log into github copilot chat
3. Install azure repos extension and log into microsoft account
4. Confirm that UI shows proper login state
5. Turn on cloud changes and reuse the previously logged in account
6. Open a new window
7. Reload the window a couple of times
8. UI misses login states across each reload

[TylerLeonhardt]

The accounts are lazy because extension activation is lazy. The two things using Microsoft here:

• Cloud Changes
• Azure Repos

Don't try to get the user's account at startup. Azure Repos doesn't because it is not activated at startup... and Cloud Changes probably doesn't ask for an account until you interact with that feature. The second you interact with Cloud Changes, your account should show up.

GitHub is there at the beginning probably because the new Copilot Free setup view @bpasero introduced basically has GitHub auth always be asked for at startup... or maybe it only happens if the Chat setup view is visible... in any case, that's likely why GitHub is there.

I don't think we want to be eager here with these extensions, but I'm up to discussion.

[bpasero]

@TylerLeonhardt can you clarify what you mean? Copilot setup only explicitly calls createSession when interacting with setup:

vscode/src/vs/workbench/contrib/chat/browser/chatSetup.ts

Line 898 in 7f434da

session = await this.authenticationService.createSession(providerId, defaultChat.providerScopes[0]);

Otherwise, to resolve entitlements, it tries to find an existing session:

vscode/src/vs/workbench/contrib/chat/browser/chatSetup.ts

Lines 487 to 502 in 7f434da

	private async findMatchingProviderSession(token: CancellationToken): Promise<AuthenticationSession | undefined> {
	const sessions = await this.doGetSessions(ChatSetupRequests.providerId(this.configurationService));
	if (token.isCancellationRequested) {
	return undefined;
	}
	for (const session of sessions) {
	for (const scopes of defaultChat.providerScopes) {
	if (this.scopesMatch(session.scopes, scopes)) {
	return session;
	}
	}
	}
	return undefined;
	}

[TylerLeonhardt]

getSesions is called.

[TylerLeonhardt]

resolve() is called in the constructor:

vscode/src/vs/workbench/contrib/chat/browser/chatSetup.ts

Line 431 in 3d0cc62

this.resolve();

which eventually calls getSessions:

vscode/src/vs/workbench/contrib/chat/browser/chatSetup.ts

Line 515 in 3d0cc62

return await this.authenticationService.getSessions(providerId);

This activates the GitHub Authentication extension so now, GitHub Authentication is always activated at startup (or close to it).

[bpasero]

Ah, this is about activation. Yes, this is required on startup.