Potential leak for WatchingProblemCollector

[mjbvz]

Type: Bug

On window reload, I'm seeing this error in the logs (deminified stack):

  ERR [193] potential listener LEAK detected, having 263 listeners already. MOST frequent listener (89):: Error
/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:185<br/>
  at onDidChangeConfiguration ([./editor/contrib/codelens/codelensWidget.ts:87:38](https://github.com/Microsoft/vscode/blob/ebe9ea85a0a0bb087dccc98949542605dfc51f6f/src/vs/./editor/contrib/codelens/codelensWidget.ts#L87))<br/>
  at [./editor/contrib/codelens/codelensWidget.ts:247:24](https://github.com/Microsoft/vscode/blob/ebe9ea85a0a0bb087dccc98949542605dfc51f6f/src/vs/./editor/contrib/codelens/codelensWidget.ts#L247)<br/>
  at [./editor/contrib/codelens/codelensController.ts:253:23](https://github.com/Microsoft/vscode/blob/ebe9ea85a0a0bb087dccc98949542605dfc51f6f/src/vs/./editor/contrib/codelens/codelensController.ts#L253)<br/>
  at func ([./editor/browser/view/viewImpl.ts:589:9](https://github.com/Microsoft/vscode/blob/ebe9ea85a0a0bb087dccc98949542605dfc51f6f/src/vs/./editor/browser/view/viewImpl.ts#L589))<br/>
  at callback ([./editor/browser/view/viewImpl.ts:498:18](https://github.com/Microsoft/vscode/blob/ebe9ea85a0a0bb087dccc98949542605dfc51f6f/src/vs/./editor/browser/view/viewImpl.ts#L498))<br/>
  at func ([./editor/browser/view/viewImpl.ts:581:9](https://github.com/Microsoft/vscode/blob/ebe9ea85a0a0bb087dccc98949542605dfc51f6f/src/vs/./editor/browser/view/viewImpl.ts#L581))<br/>
  at safeInvokeNoArg ([./editor/browser/view/viewImpl.ts:359:10](https://github.com/Microsoft/vscode/blob/ebe9ea85a0a0bb087dccc98949542605dfc51f6f/src/vs/./editor/browser/view/viewImpl.ts#L359))<br/>
  at _renderOnce ([./editor/browser/view/viewImpl.ts:478:7](https://github.com/Microsoft/vscode/blob/ebe9ea85a0a0bb087dccc98949542605dfc51f6f/src/vs/./editor/browser/view/viewImpl.ts#L478))<br/>
  at change ([./editor/browser/widget/codeEditorWidget.ts:1247:40](https://github.com/Microsoft/vscode/blob/ebe9ea85a0a0bb087dccc98949542605dfc51f6f/src/vs/./editor/browser/widget/codeEditorWidget.ts#L1247))<br/>
  at changeViewZones ([./editor/contrib/codelens/codelensController.ts:222:16](https://github.com/Microsoft/vscode/blob/ebe9ea85a0a0bb087dccc98949542605dfc51f6f/src/vs/./editor/contrib/codelens/codelensController.ts#L222))<br/>
  at callback ([./editor/common/model/textModel.ts:1502:12](https://github.com/Microsoft/vscode/blob/ebe9ea85a0a0bb087dccc98949542605dfc51f6f/src/vs/./editor/common/model/textModel.ts#L1502))<br/>
  at _changeDecorations ([./editor/common/model/textModel.ts:1467:15](https://github.com/Microsoft/vscode/blob/ebe9ea85a0a0bb087dccc98949542605dfc51f6f/src/vs/./editor/common/model/textModel.ts#L1467))<br/>
  at changeDecorations ([./editor/browser/widget/codeEditorWidget.ts:1019:31](https://github.com/Microsoft/vscode/blob/ebe9ea85a0a0bb087dccc98949542605dfc51f6f/src/vs/./editor/browser/widget/codeEditorWidget.ts#L1019))<br/>
  at changeDecorations ([./editor/contrib/codelens/codelensController.ts:221:15](https://github.com/Microsoft/vscode/blob/ebe9ea85a0a0bb087dccc98949542605dfc51f6f/src/vs/./editor/contrib/codelens/codelensController.ts#L221))<br/>
  at _renderCodeLensSymbols ([./editor/contrib/codelens/codelensController.ts:121:10](https://github.com/Microsoft/vscode/blob/ebe9ea85a0a0bb087dccc98949542605dfc51f6f/src/vs/./editor/contrib/codelens/codelensController.ts#L121))<br/>
  at hasListeners ([./base/common/event.ts:302:11](https://github.com/Microsoft/vscode/blob/ebe9ea85a0a0bb087dccc98949542605dfc51f6f/src/vs/./base/common/event.ts#L302))<br/>

VS Code version: Code - Insiders 1.97.0-insider (Universal) (63c0355, 2025-01-30T05:04:51.529Z)
OS version: Darwin arm64 24.2.0
Modes:

System Info

Item	Value
CPUs	Apple M2 Max (12 x 2400)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: enabled_on direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_graphite: disabled_off video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled webgpu: enabled webnn: disabled_off
Load (avg)	11, 7, 6
Memory (System)	64.00GB (0.33GB free)
Process Argv	--enable-proposed-api ms-vscode.sample-inline-edit-provider --crash-reporter-id 0fffb5da-9cd7-46fd-9e7f-a1564e8c5fda
Screen Reader	no
VM	0%

[jrieken]

@mattbierner do you still have the minified stacktrace? Inside codelensWidget.ts no call of onDidChangeConfiguration exsits, only in the code lens contribution for which only one per editor instance should exist. Do you somehow have very many editors open?

[mjbvz]

Sure here's the original stack:

   at Pfi.create (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:27:11832)
    at P4.q [as onMarkerChanged] (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:29:1377)
    at Object.onWillAddFirstListener (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:27:7141)
    at q (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:29:1565)
    at wte.value (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2586:5572)
    at x.B (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:29:2392)
    at x.C (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:29:2462)
    at x.fire (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:29:2680)
    at c3e.N (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:699:2293)
    at vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:698:2675

had around 20 editor tabs opened when I saw this yesterday

[jrieken]

This is even more confusing now, the onMarkerChanged isn't used anywhere in codelens land. I think the deminifier tool is broken

[jrieken]

This is from here

vscode/src/vs/workbench/contrib/tasks/common/problemCollectors.ts

Line 439 in 33945ac

Event.debounce(this.markerService.onMarkerChanged, (last: readonly URI[] | undefined, e: readonly URI[]) => {