Git: Encoding not recognized: 'utf8bom' (searched as: 'utf8bom')

[smashedtoatoms]

I am getting the following error in Insider when staging changes: Git: Encoding not recognized: 'utf8bom' (searched as 'utf8bom'). This does not occur in standard.

[smashedtoatoms]

I used the report issue feature in Code, but this ticket doesn't appear to have any data attached to it.

The issue does happen with extensions disabled.

Version: 1.98.0-insider
Commit: b7d674d
Date: 2025-02-26T05:04:34.242Z (19 hrs ago)
Electron: 34.2.0
ElectronBuildId: 11044223
Chromium: 132.0.6834.196
Node.js: 20.18.2
V8: 13.2.152.36-electron.0
OS: Darwin arm64 24.3.0

macOS: 15.3.1 (24D70)

Steps to Reproduce:

1. Make a change in a file in a git project.
2. Stage a single line in the gui.

[lszomoru]

@smashedtoatoms, could you please share the steps to reproduce this? Thanks!

[smashedtoatoms]

1. Open a file in a project that uses git
2. Add a line to the file
3. Click on the green to the left of the added line
4. Click the stage change + button on the right of the screen that comes up
5. Witness error popup saying "Git: Encoding not recognized: 'utf8bom' (searched as: 'utf8bom')"

[bpasero]

@lszomoru this reproduces if you first save the file as encoding UTF8 with BOM. I cannot see any issues with the new APIs that I added (see 2083d85 for a test), but I wonder if maybe you pass the raw utf8bom encoding to a tool like iconv-lite somewhere else?

Here I still see it being used:

vscode/extensions/git/src/git.ts

Line 1665 in 9f0f696

child.stdin!.end(iconv.encode(data, encoding));

Note that utf8bom is something VS Code invented, it does NOT exist in iconv-lite, so that would explain the error. In iconv-lite you need to addBOM: true in that case. I would suggest to move away from using both iconv-lite and jschardet. I had actually thought you had already moved away 🤔