Add toggle support for QuickInput/QuickPick, resourceUri support for QuickPickItem#271598
Merged
TylerLeonhardt merged 44 commits intomainfrom Oct 18, 2025
Merged
Add toggle support for QuickInput/QuickPick, resourceUri support for QuickPickItem#271598TylerLeonhardt merged 44 commits intomainfrom
TylerLeonhardt merged 44 commits intomainfrom
Conversation
dmitrivMS
commented
Oct 15, 2025
dmitrivMS
commented
Oct 15, 2025
joe10832
reviewed
Oct 15, 2025
dmitrivMS
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds toggle support for QuickInput/QuickPick widgets and resourceUri support for QuickPickItems. The changes enable extensions to add toggle buttons within the input box area and automatically derive labels, descriptions, and icons for items that represent file/folder resources.
Key Changes
- Added toggle button support for QuickInput with a new
Inputlocation type inQuickInputButtonLocationenum - Added
resourceUriproperty to QuickPickItem for automatic resource-based label/icon derivation - Refactored icon handling to use a unified
IconPathDtotype and converter functions
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/api/common/extHostTypes.ts |
Added Input = 3 to QuickInputButtonLocation enum for toggle buttons |
src/vs/workbench/api/common/extHostTypeConverters.ts |
Added IconPath.from() and IconPath.to() converters for unified icon handling |
src/vs/workbench/api/common/extHostQuickOpen.ts |
Updated QuickInput implementation to support toggles and resourceUri, removed duplicate icon conversion logic |
src/vs/workbench/api/common/extHost.protocol.ts |
Added IconPathDto type and protocol updates for toggle/resourceUri support |
src/vs/workbench/api/browser/mainThreadQuickOpen.ts |
Implemented toggle widget creation and resource URI expansion logic |
src/vs/platform/quickinput/common/quickInput.ts |
Moved toggles property from IQuickPick to base IQuickInput interface |
src/vs/platform/extensions/common/extensionsApiProposals.ts |
Added quickPickItemResource API proposal |
dmitrivMS
commented
Oct 16, 2025
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
TylerLeonhardt
approved these changes
Oct 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #144956 and #59826